Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mdx-loader): add support for siteConfig.markdown.remarkRehypeOptions #9674

Merged
merged 4 commits into from
Dec 27, 2023

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Dec 27, 2023

Motivation

Makes it possible to provide custom remark-rehype options, documented at https://github.com/remarkjs/remark-rehype#options

Fix #9502

Fix #8743

Test Plan

Unit tests + dogfood

Local test shows it's now possible to translate the footnoteLabel, among other things

CleanShot 2023-12-27 at 20 26 27@2x

Test links

Docs: https://deploy-preview-9674--docusaurus-2.netlify.app/docs/api/docusaurus-config#markdown

@slorber slorber added pr: new feature This PR adds a new API or behavior. to backport This PR is planned to be backported to a stable version of Docusaurus labels Dec 27, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 27, 2023
Copy link

netlify bot commented Dec 27, 2023

[V2]

Name Link
🔨 Latest commit d846d03
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/658c79ccf5305b0008b447aa
😎 Deploy Preview https://deploy-preview-9674--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@slorber slorber added the Argos Add this label to run UI visual regression tests. See argos.yml GH action. label Dec 27, 2023
Copy link

netlify bot commented Dec 27, 2023

[V2]

Name Link
🔨 Latest commit 1b8fda6
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/658c7a223ba81200088d2a56
😎 Deploy Preview https://deploy-preview-9674--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 27, 2023

[V2]

Name Link
🔨 Latest commit b6861db
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/658c9f3357864e0008a0667d
😎 Deploy Preview https://deploy-preview-9674--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 27, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 68 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/installation 🟠 69 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog 🟠 75 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 65 🟢 97 🟢 100 🟢 100 🟠 89 Report
/blog/tags/release 🟠 75 🟢 100 🟢 100 🟠 80 🟠 89 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 89 Report

Copy link

argos-ci bot commented Dec 27, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 124 changes Jan 5, 2024, 6:56 PM

Copy link

github-actions bot commented Dec 27, 2023

Size Change: +48 B (0%)

Total Size: 926 kB

Filename Size Change
website/build/assets/js/main.********.js 716 kB +48 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 59.2 kB
website/build/assets/css/styles.********.css 114 kB
website/build/index.html 37.6 kB

compressed-size-action

@slorber slorber merged commit bfb882c into main Dec 27, 2023
32 checks passed
@slorber slorber deleted the slorber/remarkRehypeOptions branch December 27, 2023 22:19
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the footnote label "Footnotes" should be able to be translated
2 participants