Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blog): author header social icons #10222
feat(blog): author header social icons #10222
Changes from 6 commits
27479a4
c3a8ad5
51a8e08
7c45cfc
a93f742
685b2fe
30022fc
0ab5afd
be05dc7
eb4a2fc
0c26f22
e98b0ed
dec190e
39d7403
0e19baf
f83e860
bb08c72
9395d5f
45e4950
7ad8bed
eb5522f
a2071f9
3429481
7905a5b
fd2b81a
8641bef
9ed1e6a
ccc6a04
d19480d
5e1723f
605ceed
229c4c2
b3d5942
4975427
c01fe89
e0b54ae
9005a4f
91ca3af
f8dc2f8
42dae65
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we'd want to have
.unknown()
to allow users to pass extra social platforms?We could render them with 🔗 or 🌐 icon by default?
Note your type already supports extra attributes (
[key: string]: string;
) so validation should do it as wellAnd unit tests should ensure we reject things that we don't want, like
{twitch: {xyz: 42}}
. I think you needJoi.object().pattern()
for that.