Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): ignored className attribute on lazy loaded TabItem #10219

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

lebalz
Copy link
Contributor

@lebalz lebalz commented Jun 14, 2024

Fixes #10218

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@lebalz lebalz requested review from slorber and Josh-Cena as code owners June 14, 2024 16:33
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 14, 2024
Copy link

netlify bot commented Jun 14, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit b013ea9
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6670900c64f27e0008bd7409
😎 Deploy Preview https://deploy-preview-10219--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jun 14, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 61 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 61 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 70 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 62 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟢 90 🟠 88 Report

@slorber slorber changed the title fix ignored className attribute on lazy loaded TabItem fix(theme): ignored className attribute on lazy loaded TabItem Jun 17, 2024
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jun 17, 2024
@slorber
Copy link
Collaborator

slorber commented Jun 17, 2024

Thanks 👍

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lebalz
Copy link
Contributor Author

lebalz commented Jun 17, 2024

Doesn't seem to work

See repro using swizzle:

https://stackblitz.com/edit/github-ez2gpv?file=src%2Fpages%2Findex.tsx,src%2Fpages%2Findex.module.css,src%2Ftheme%2FTabs.tsx,src%2Ftheme%2Fstyles.module.css

Don't know how i messed up my setup that i had the impression it worked - sorry for the trouble.

With your hint, it now works, and i extended the dogfooding /pages/tabs-tests/ that shows the new behaviour:

https://deploy-preview-10219--docusaurus-2.netlify.app/tests/pages/tabs-tests/

@slorber
Copy link
Collaborator

slorber commented Jun 18, 2024

Thanks 👍

@slorber slorber merged commit 591914c into facebook:main Jun 18, 2024
32 checks passed
@lebalz lebalz deleted the patch-1 branch June 18, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TabItem ignores className if lazy attribute is set
3 participants