-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mdx-loader): resolve Markdown/MDX links with Remark instead of RegExp #10168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⚡️ Lighthouse report for the deploy preview of this PR
|
7 tasks
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: +2.56 kB (+0.15%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
slorber
added
the
Argos
Add this label to run UI visual regression tests. See argos.yml GH action.
label
May 24, 2024
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This was referenced Sep 8, 2024
This was referenced Sep 13, 2024
This was referenced Sep 28, 2024
This was referenced Sep 29, 2024
Closed
This was referenced Oct 4, 2024
This was referenced Oct 19, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Argos
Add this label to run UI visual regression tests. See argos.yml GH action.
CLA Signed
Signed Facebook CLA
pr: bug fix
This PR fixes a bug in a past release.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implement proper resolution of Markdown links (
[title](./file.md)
)We process the AST with Remark instead of a raw string with complex RegExp that don't understand well HTML/MDX comments, code blocks, etc...
Fix #9048
Note:
Test Plan
Unit tests + dogfooding (all links on our website should keep resolving as before + new fancy cases added from the initial issue)
Test links
https://deploy-preview-10168--docusaurus-2.netlify.app/