Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: recommend users to remove hast-util-is-element in migration to v3 #10143

Merged
merged 1 commit into from
May 16, 2024

Conversation

tats-u
Copy link
Contributor

@tats-u tats-u commented May 16, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Docusaurus v3 doesn't depend on hast-util-is-element unlike v2.

v2: https://docusaurus.io/docs/2.x/markdown-features/math-equations#configuration
v3: https://docusaurus.io/docs/markdown-features/math-equations#configuration

We probably can remove it when upgrading Docusaurus from v2 to v3.

Test Plan

https://docusaurus.io/docs/migration/v3#upgrading-math-packages

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@tats-u tats-u requested review from slorber and Josh-Cena as code owners May 16, 2024 15:42
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 16, 2024
Copy link

netlify bot commented May 16, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 4291c19
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66462973c6fab20008794be5
😎 Deploy Preview https://deploy-preview-10143--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 60 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 57 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 66 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 62 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 66 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label May 16, 2024
@slorber
Copy link
Collaborator

slorber commented May 16, 2024

thanks 👍

@slorber slorber merged commit 562a0be into facebook:main May 16, 2024
13 checks passed
@tats-u tats-u deleted the remove-hast-util-is-element branch May 16, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants