-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): codegen should generate unique route prop filenames #10131
Merged
slorber
merged 2 commits into
main
from
slorber/fix-route-module-props-filename-conflict
May 10, 2024
Merged
fix(core): codegen should generate unique route prop filenames #10131
slorber
merged 2 commits into
main
from
slorber/fix-route-module-props-filename-conflict
May 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: -33 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
This was referenced Jun 22, 2024
This was referenced Jun 22, 2024
This was referenced Jun 22, 2024
This was referenced Sep 8, 2024
This was referenced Sep 13, 2024
This was referenced Sep 28, 2024
This was referenced Sep 29, 2024
Closed
This was referenced Oct 4, 2024
This was referenced Oct 19, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #10125
When using docs
routeBasePath: '/'
and a category withslug: '/'
, we end up with 2 prop module files namedindex.json
in the plugin props dir, and one overrides the other leading to issues.To solve this, we now always append a hash (previously there was an exception for path
/
returningindex
) that depends on both the route path but also the component name. It makes it much less likely to have a filename conflict.Note: it's still technically possible to have a conflict. A more robust solution could be to hash the props object content, but it's slower. The current solution is good enough and fast.
Test Plan
Unit test
Plus local test on the bug repro works: