Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade svgr / svgo / cssnano #10092

Merged
merged 3 commits into from
Apr 30, 2024
Merged

chore: Upgrade svgr / svgo / cssnano #10092

merged 3 commits into from
Apr 30, 2024

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Apr 30, 2024

Motivation

Upgrade dependencies that should be safe/retrocompatible

Fix #10068 - annoying install warning

Note, those dependencies are not upgraded to the latest because they drop support for Node 18.0 and Node 21.x (which Docusaurus V3 supports)

    "cssnano-preset-advanced": "^6.1.2",
    "css-minimizer-webpack-plugin": "^5.0.1",
    "cssnano": "^6.1.2",

Test Plan

CI

Test links

https://deploy-preview-10092--docusaurus-2.netlify.app/

@slorber slorber added pr: bug fix This PR fixes a bug in a past release. Argos Add this label to run UI visual regression tests. See argos.yml GH action. labels Apr 30, 2024
@slorber slorber requested a review from Josh-Cena as a code owner April 30, 2024 15:26
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 30, 2024
Copy link

netlify bot commented Apr 30, 2024

[V2]

Name Link
🔨 Latest commit 89322d8
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66310dac89001e000828a00d
😎 Deploy Preview https://deploy-preview-10092--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 30, 2024

[V2]

Name Link
🔨 Latest commit 660ef23
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6631109004e6b00008c3040c
😎 Deploy Preview https://deploy-preview-10092--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 30, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 59 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 66 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 70 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 63 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 71 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report

Copy link

argos-ci bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Apr 30, 2024, 3:45 PM

Copy link

Size Change: -777 B (-0.05%)

Total Size: 1.59 MB

Filename Size Change
website/build/assets/css/styles.********.css 112 kB -777 B (-0.69%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/codeTranslations.json 2 B
website/.docusaurus/docusaurus.config.mjs 26.7 kB
website/.docusaurus/globalData.json 91.2 kB
website/.docusaurus/i18n.json 930 B
website/.docusaurus/registry.js 247 kB
website/.docusaurus/routes.js 156 kB
website/.docusaurus/routesChunkNames.json 109 kB
website/.docusaurus/site-metadata.json 2.17 kB
website/build/assets/js/main.********.js 810 kB
website/build/index.html 38 kB

compressed-size-action

@slorber slorber merged commit be9081a into main Apr 30, 2024
31 of 32 checks passed
@slorber slorber deleted the slorber/upgrade-svgr branch April 30, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WARN  1 deprecated subdependencies found: [email protected]
2 participants