Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove project property from @typescript-eslint/parser options #6701

Merged
merged 2 commits into from
Mar 29, 2019
Merged

Remove project property from @typescript-eslint/parser options #6701

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26b2993
Remove project property from @typescript-eslint/parser options
jackwilsdon Mar 21, 2019
48a13e4
Remove unnecessary code
ianschmitz Mar 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions packages/eslint-config-react-app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,6 @@
// To use them, explicitly reference them, e.g. `window.name` or `window.status`.
const restrictedGlobals = require('confusing-browser-globals');

// The following is copied from `react-scripts/config/paths.js`.
const path = require('path');
const fs = require('fs');
// Make sure any symlinks in the project folder are resolved:
// https://github.com/facebook/create-react-app/issues/637
const appDirectory = fs.realpathSync(process.cwd());
const resolveApp = relativePath => path.resolve(appDirectory, relativePath);
const projectRootPath = resolveApp('.');
const tsConfigPath = resolveApp('tsconfig.json');

module.exports = {
root: true,

Expand Down Expand Up @@ -73,8 +63,6 @@ module.exports = {
},

// typescript-eslint specific options
project: tsConfigPath,
tsconfigRootDir: projectRootPath,
warnOnUnsupportedTypeScriptVersion: true,
},
plugins: ['@typescript-eslint'],
Expand Down