Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serve port flag and add example #6229

Merged
merged 2 commits into from
Jan 20, 2019
Merged

Update serve port flag and add example #6229

merged 2 commits into from
Jan 20, 2019

Conversation

lyzhovnik
Copy link
Contributor

Hi everyone! Thank for this awesome project! I enjoy this a lot and use it in my react projects!

So, I needed to run front-end with serve library with my costume port, I made some reserch about all flags and docs about serve and noticed that frags which are on the CRA website are still working, but they are deprecated and serve lib recommends to use flag -l instead of -p, this discussion is in vercel/serve#382 issue, and also you can see this in serve code:
https://github.com/zeit/serve/blob/85d121e5008783395cc607089f23a5039547f952/bin/serve.js#L258

This pull request updates serve ports and adds example of using costume ports with serve lib

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@iansu iansu added this to the 2.1.4 milestone Jan 20, 2019
@iansu iansu merged commit 1c591cb into facebook:master Jan 20, 2019
@iansu
Copy link
Contributor

iansu commented Jan 20, 2019

Thanks!

@lock lock bot locked and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants