Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to docs in all package README files #5912

Merged
merged 3 commits into from
Dec 6, 2018

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Nov 27, 2018

There are also a lot of links to the old README in the CHANGELOGs but I don't know if we want to update those.

@iansu
Copy link
Contributor Author

iansu commented Nov 27, 2018

Somehow these changes are breaking the behaviour test suite. 😂

@Timer Any idea why this might be happening? It must have something to do with the change to packages/react-scripts/bin/react-scripts.js.

@deftomat
Copy link
Contributor

deftomat commented Nov 28, 2018

AppVeyor failed due to 60 minutes limit. The same happened to PR #5903.

There is probably a limit for open-source projects.

@netlify
Copy link

netlify bot commented Dec 6, 2018

Deploy preview for create-react-app ready!

Built with commit 49b41a6

https://deploy-preview-5912--create-react-app.netlify.com

@iansu iansu force-pushed the update-readme-doc-links branch from 9ccef3d to 49b41a6 Compare December 6, 2018 20:09
@iansu iansu added this to the 2.1.2 milestone Dec 6, 2018
@iansu iansu merged commit 7513481 into facebook:master Dec 6, 2018
timsnadden added a commit to timsnadden/create-react-app that referenced this pull request Dec 7, 2018
* master: (39 commits)
  Added extension to .eslintrc (facebook#5988)
  Update links to docs in all package README files (facebook#5912)
  Use https for linked images in docs to fix mixed content warnings (facebook#5985)
  Improve error messaging in verifyPackageTree.js (facebook#5974)
  Add removeItem to localStorage mock in docs (facebook#5919)
  Add SASS_PATH instructions to Sass docs (facebook#5917)
  Suggest a different default for speed reasons (facebook#5959)
  Add pre-eject message about new features in v2 (facebook#5954)
  Add netlify.toml to prepare for deploy to netlify facebook#5807 (facebook#5930)
  Correct some comments (facebook#5927)
  Add note to docs about using Sass and Flow together (facebook#5823)
  Update PWA link in README (facebook#5907)
  Add placeholders to template README for bit.ly links. (facebook#5808)
  Disable copy to clipboard in cra --info (facebook#5905)
  Support setupTests.ts (facebook#5698)
  Remove unnecessary whitespace in template HTML
  Run prettier on HTML files (facebook#5839)
  Some Grammar fixes (facebook#5858)
  Fix link to page about running tests (facebook#5883)
  fix: make typescriptformatter support 0.5 of fork checker (facebook#5879)
  ...
mrmckeb pushed a commit to BeameryHQ/bmr-react-scripts that referenced this pull request Dec 20, 2018
* Update links to docs in all package README files

* Fix formatting of issue template

* Fix formatting of issue template
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
@iansu iansu deleted the update-readme-doc-links branch October 17, 2019 23:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants