Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the latest stable node version #5546

Merged
merged 1 commit into from Nov 23, 2018
Merged

Add the latest stable node version #5546

merged 1 commit into from Nov 23, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 23, 2018

Summary

This PR adds node since Node.js 11 has been released.

https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V11.md#11.0.0

Details

Specifying Node.js versions

Specifying Node.js versions #
The easiest way to specify Node.js versions is to use one or more of the latest releases in your .travis.yml:

node latest stable Node.js release
iojs latest stable io.js release
lts/* latest LTS Node.js release

@iansu
Copy link
Contributor

iansu commented Oct 23, 2018

We should decide how we want to handle non-LTS releases. I think this config might make sense. We explicitly list the LTS releases we support and then just use node to catch the latest version.

When node 10 was the latest, if we had 10 and node, would that have run the test suite on node 10 twice? I guess we'll find out when node 12 comes out.

@ghost
Copy link
Author

ghost commented Oct 23, 2018

@iansu Hi,
We can decide on how to handle the testing overhead.
To decide that you might want to check out this:

Why Adding “node”?

In short: To fail early for new Node.js releases.

At the time of writing this tutorial, the latest Node.js version is 9.x. That means Travis runs tests with the same environment for the configured versions 9 and node. Both run Node.js v9.

In some months, there will be a Node.js v10 release. At that point, the node config points to version 10 instead of 9.

While updating a project you’ll see at an early stage whether it's compatible with the new Node.js major release.

There’s no additional configuration required to test against the next Node.js release. It’s an early heads up for required maintenance.

Eventually you should add the related Node.js version represented by node to your .travis.yml. For an early heads up, it’s a great way to recognize failing tests.

Should You Worry About the Testing Overhead?

As mentioned above, most of the time you’re running tests against the same versions when using a dedicated version number (like 9) and node. This will test your project twice against the same environment.

Well, for us it’s worth testing a repository against the same Node.js twice for most of the time, because testing is cheap.

Be proactive in testing rather than running behind compatibility and needing manual work to test against the latest stable release.

@iansu
Copy link
Contributor

iansu commented Oct 23, 2018

So it does run it twice. Maybe that doesn't matter if they run in parallel.

@stale
Copy link

stale bot commented Nov 23, 2018

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Nov 23, 2018
@iansu iansu removed the stale label Nov 23, 2018
@iansu iansu modified the milestones: 2.1.x, 2.1.2 Nov 23, 2018
@iansu iansu merged commit 1164f6b into facebook:master Nov 23, 2018
@iansu
Copy link
Contributor

iansu commented Nov 23, 2018

Thanks!

dardub added a commit to OffBase/create-react-app that referenced this pull request Nov 27, 2018
* upstream/master: (210 commits)
  Support setupTests.ts (facebook#5698)
  Remove unnecessary whitespace in template HTML
  Run prettier on HTML files (facebook#5839)
  Some Grammar fixes (facebook#5858)
  Fix link to page about running tests (facebook#5883)
  fix: make typescriptformatter support 0.5 of fork checker (facebook#5879)
  Always test with the latest stable Node version on Travis (facebook#5546)
  Fix propertyDecorator test
  Upgrade babel deps
  Fix annotated var test
  Fix TypeScript decorator support (facebook#5783)
  fix: add `sideEffects: false` to react-error-overlay (facebook#5451)
  Add allowESModules option to babel-preset-react-app (facebook#5487)
  Make named-asset-import plugin work with export-as syntax (facebook#5573)
  React native repository updated in README.md (facebook#5849)
  extra polyfills must be included manually (facebook#5814)
  Rename 'getting started' link to 'docs' (facebook#5806)
  docs: Simplify installing Storybook with npx (facebook#5788)
  Don't polyfill fetch for Node -- additional files (facebook#5789)
  docs: Change Storybook install documentation (facebook#5779)
  ...
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants