Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint-plugin-jsx-a11y version #5330

Merged
merged 1 commit into from
Oct 6, 2018

Conversation

AlmeroSteyn
Copy link
Contributor

Updated the version of eslint-plugin-jsx-a11y from 6.1.1 to 6.1.2.

Properly closes #4141

Adds clearer error messages for the anchor-is-valid rule as per https://github.com/evcohen/eslint-plugin-jsx-a11y/pull/486.

@AlmeroSteyn
Copy link
Contributor Author

Ok, I came back later and saw that the Travis build had failed. I tried to run tests locally but, as indicated in the docs, this take a bit more effort on Windows. Locally my tests then seem to fail on some snapshot test error. I think this totally unrelated and has something to do with my enviroment.

Will need to check this out, but I'm out of time for the weekend. Unless someone can check if this is related to upgrading the one package or something else. Or if someone can point me in the right direction as to why this is failing.

I see the following but not the reason why it failed:

e2e-installs.sh: ERROR! An error was encountered executing line 47.
Cleaning up.
yarn config v1.13.0-20181006.0202
success Set "registry" to "https://registry.yarnpkg.com".
Exiting with error.
The command "if [ $TEST_SUITE = "installs" ]; then tasks/e2e-installs.sh; fi" exited with 1.
0.00s$ if [ $TEST_SUITE = "kitchensink" ]; then tasks/e2e-kitchensink.sh; fi

@bugzpodder
Copy link

test is sometimes flaky, try retriggering the CI by adding a few no-ops (like a blank line).

@Timer Timer added this to the 2.0.5 milestone Oct 6, 2018
@Timer Timer merged commit 81830dc into facebook:master Oct 6, 2018
@Timer
Copy link
Contributor

Timer commented Oct 6, 2018

Thanks!

@AlmeroSteyn AlmeroSteyn deleted the update-eslint-plugin-jsx-a11y branch October 7, 2018 08:05
@Timer Timer mentioned this pull request Oct 8, 2018
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint rules don't allow links with javascript:void href, or any alternative.
4 participants