Disable webpack chunk coalescing #5030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this! |
This reverts commit 84632115d178b48e08eb75dc5e9a921ece6aa759.
Timer
force-pushed
the
feature/fix-chunking
branch
from
8463211 to
77f60ed
Compare
|
Excellent stuff Timer! |
|
We'll figure CI out another time ... |
|
Note |
|
The Medium article made it sound like this would cause unnecessary cache invalidation, but I think we'd rather have the smaller names anyway. Thanks @sokra! |
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Sep 30, 2018
* Disable webpack chunk rollup * Bump timeout * Revert "Bump timeout" This reverts commit 84632115d178b48e08eb75dc5e9a921ece6aa759.
GabeDuarteM
added a commit
to GabeDuarteM/gd-scripts
that referenced
this pull request
Oct 29, 2018
see facebook/create-react-app#5030 for more info
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #4977, closes #4632, closes #4769, closes #4633
Disabling chunk rollup results in much better bundle distribution.
Off topic, it also makes webpack blazing fast!
This is the recommendation made in the code splitting blog post by @sokra.
It says setting
{ name: false }will prevent bundle invalidation as more chunks are added, but we'll see ...v1.1.4
Optimal chunk distribution, 65 second build time:
v2.0.0-next.a671462c
Suboptimal chunk rollup (see 1MB chunk, 91 second build time):
This PR:
Optimal chunk distribution (compare to v1, 56 second build time):
This PR + Warm Cache (39 seconds!!!):
