-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webpack 4 scope hoisting #4504
webpack 4 scope hoisting #4504
Conversation
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email [email protected] with your details so we can update your status. |
Wow, thanks for following up on this @bugzpodder. |
@bugzpodder Is CLA form working for you? I can follow up internally if it's broken |
@gaearon it is broken for me, let me try emailing [email protected] first. if it doesnt work will let you know. |
Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice job with the follow-up!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
FYI @bugzpodder you've been very helpful with fixing CI and these follow-ups, and you should get an invite to be collaborator on this repo soon. Please seek consensus with at least one existing maintainer before merging something big or risky but consider this an invitation to fix things that are broken :-) |
Awesome, great job @bugzpodder 👍 |
Upgrade to new webpack-manifest-plugin 2.0.3
#4492
shellscape/webpack-manifest-plugin#151
shellscape/webpack-manifest-plugin#152