Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add troubleshooting for Github Pages #4197

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Conversation

xnt
Copy link

@xnt xnt commented Mar 21, 2018

Add troubleshooting for an issue that has to do with either 2FA, or using Windows, or both, when trying to deploy an app via gh-pages .

Proactively fixes #4196

Add troubleshooting for an issue that has to do with either 2FA, or using Windows, or both, when trying to deploy an app via gh-pages
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@xnt
Copy link
Author

xnt commented Mar 22, 2018

I think this is broken due to CI issues mostly. Can anyone let me know if that's not the case?

@andriijas andriijas added this to the 2.0.0 milestone Mar 23, 2018
@andriijas andriijas merged commit cb1608b into facebook:master Mar 23, 2018
@andriijas
Copy link
Contributor

Thanks!

@gaearon
Copy link
Contributor

gaearon commented Apr 2, 2018

@andriijas I think this should have been merged into next :-)

gaearon pushed a commit that referenced this pull request Apr 2, 2018
Add troubleshooting for an issue that has to do with either 2FA, or using Windows, or both, when trying to deploy an app via gh-pages
bors bot referenced this pull request in mythmon/corsica-tree-status Apr 23, 2018
3: Update dependency flow-bin to v0.70.0 r=mythmon a=renovate[bot]

This Pull Request updates dependency [flow-bin](https://github.com/flowtype/flow-bin) from `v0.66.0` to `v0.70.0`




<details>
<summary>Commits</summary>

#### v0.67.1
-   [`4255e2d`](flow/flow-bin@4255e2d) v0.67.1
#### v0.68.0
-   [`aea9bb5`](flow/flow-bin@aea9bb5) v0.68.0
#### v0.69.0
-   [`b8a5da6`](flow/flow-bin@b8a5da6) v0.69.0
#### v0.70.0
-   [`0b0bcea`](flow/flow-bin@0b0bcea) v0.70.0

</details>



---

This PR has been generated by [Renovate Bot](https://renovateapp.com).

4: Update dependency react-scripts to v1.1.4 r=mythmon a=renovate[bot]

This Pull Request updates dependency [react-scripts](https://github.com/facebookincubator/create-react-app) from `v1.1.1` to `v1.1.4`



<details>
<summary>Release Notes</summary>

### [`v1.1.2`](https://github.com/facebookincubator/create-react-app/blob/master/CHANGELOG.md#&#8203;112-April-3-2018)

##### 🐛 Bug Fix

* `react-scripts`

  * [#&#8203;4085](`https://github.com/facebook/create-react-app/pull/4085`) Resolve `.js` before `.mjs` files to unbreak dependencies with native ESM support. ([@&#8203;leebyron])
##### 📝 Documentation

* `react-scripts`

  * [#&#8203;4197](`https://github.com/facebook/create-react-app/pull/4197`) Add troubleshooting for Github Pages. ([@&#8203;xnt])
##### Committers: 2
- Lee Byron ([leebyron])
- Vicente Plata ([xnt])
##### Migrating from 1.1.1 to 1.1.2

Inside any created project that has not been ejected, run:

```
npm install --save --save-exact react-scripts@&#8203;1.1.2
```

or

```
yarn add --exact react-scripts@&#8203;1.1.2
```

---

### [`v1.1.3`](https://github.com/facebookincubator/create-react-app/blob/master/CHANGELOG.md#&#8203;113-April-3-2018)

##### 🐛 Bug Fix

* `react-scripts`

  * [#&#8203;4247](`https://github.com/facebook/create-react-app/pull/4247`) Fix `environment.dispose is not a function` error caused by a Jest bug. ([@&#8203;gaearon])
##### Committers: 1
- Dan Abramov ([gaearon])
##### Migrating from 1.1.2 to 1.1.3

Inside any created project that has not been ejected, run:

```
npm install --save --save-exact react-scripts@&#8203;1.1.3
```

or

```
yarn add --exact react-scripts@&#8203;1.1.3
```

---

### [`v1.1.4`](https://github.com/facebookincubator/create-react-app/blob/master/CHANGELOG.md#&#8203;114-April-3-2018)

##### 🐛 Bug Fix

* `react-dev-utils`

  * [#&#8203;4250](`https://github.com/facebook/create-react-app/pull/4250`) Upgrade `detect-port-alt` to fix [#&#8203;4189](`https://github.com/facebook/create-react-app/issues/4189`). ([@&#8203;Timer])
##### Committers: 1
- Joe Haddad ([Timer])
##### Migrating from 1.1.3 to 1.1.4

Inside any created project that has not been ejected, run:

```
npm install --save --save-exact react-scripts@&#8203;1.1.4
```

or

```
yarn add --exact react-scripts@&#8203;1.1.4
```

---

</details>


<details>
<summary>Commits</summary>

#### v1.1.2
-   [`058d03f`](facebook/create-react-app@058d03f) Fix typos in example monorepo documentation. (#&#8203;4164)
-   [`1922f4d`](facebook/create-react-app@1922f4d) Allow ModuleScopePlugin accecpts an array as its appSrc (#&#8203;4138)
-   [`33f1294`](facebook/create-react-app@33f1294) Revert &quot;Change no-unused-vars &#x27;args&#x27; from none to all to show warning on destructured objects&quot;
-   [`8a34b7c`](facebook/create-react-app@8a34b7c) Add ESLint check for incorrect propTypes usage (#&#8203;3840) (#&#8203;4048)
-   [`8db5e33`](facebook/create-react-app@8db5e33) Revert lint-related changes made in #&#8203;4193 (#&#8203;4211)
-   [`06dd17e`](facebook/create-react-app@06dd17e) add `create-react-app --help` info for local file path `--scripts-version` support (#&#8203;4015)
-   [`9c167a4`](facebook/create-react-app@9c167a4) Add some stuff that requires transpilation. (#&#8203;4174)
-   [`da518d2`](facebook/create-react-app@da518d2) Fix floating caret position incorrect while scrolling overlay (#&#8203;4024)
-   [`2824bf2`](facebook/create-react-app@2824bf2) [next] Revert to use ecma 5 in uglifyOptions (#&#8203;4234)
-   [`9a99b5d`](facebook/create-react-app@9a99b5d) Fix typo and be clearer about `ecma` settings in uglifyjs options (#&#8203;4239)
-   [`9c3f03c`](facebook/create-react-app@9c3f03c) use the lastest url of gitignore file (#&#8203;4236)
#### v1.1.3
-   [`061d1e4`](facebook/create-react-app@061d1e4) Add troubleshooting for Github Pages (#&#8203;4197)
-   [`2e690e9`](facebook/create-react-app@2e690e9) Add 1.1.2 changelog (#&#8203;4242)
#### v1.1.4
-   [`3b102fe`](facebook/create-react-app@3b102fe) Work around Jest environment resolving bug (#&#8203;4247)
-   [`90c908e`](facebook/create-react-app@90c908e) Changelog for 1.1.3
-   [`2762924`](facebook/create-react-app@2762924) Update detect-port-alt

</details>



---

This PR has been generated by [Renovate Bot](https://renovateapp.com).

Co-authored-by: Renovate Bot <[email protected]>
vojtechsimetka added a commit to Giveth/create-react-app that referenced this pull request May 28, 2018
* 'master' of https://github.com/facebook/create-react-app: (220 commits)
  Publish
  Changelog for 1.1.4
  Update detect-port-alt (facebook#4250)
  Publish
  Changelog for 1.1.3
  Work around Jest environment resolving bug (facebook#4247)
  Publish
  Add 1.1.2 changelog (facebook#4242)
  Add troubleshooting for Github Pages (facebook#4197)
  `.mjs` should not resolve before .js files (facebook#4085)
  Publish
  Revert "Set the public path to the asset manifest entries (facebook#2544)"
  Add 1.1.1 changelog
  Unpin and bump fsevents (for 1.x branch) (facebook#4006)
  Update dotenv-expand to fix bug with environment variables that contain a $. (facebook#4000)
  Update instructions for continuous delivery with Netlify (facebook#3971)
  Include `{json,css}` files in prettier command (facebook#3894)
  Set the public path to the asset manifest entries (facebook#2544)
  1.5.1
  pin envinfo version to 3.4.2 (facebook#3853)
  ...

# Conflicts:
#	packages/react-scripts/config/webpack.config.prod.js
#	packages/react-scripts/package.json
Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018
Add troubleshooting for an issue that has to do with either 2FA, or using Windows, or both, when trying to deploy an app via gh-pages
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Aug 14, 2018
Add troubleshooting for an issue that has to do with either 2FA, or using Windows, or both, when trying to deploy an app via gh-pages
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
Add troubleshooting for an issue that has to do with either 2FA, or using Windows, or both, when trying to deploy an app via gh-pages
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gh-Pages on Windows requires modifying the git remote
4 participants