Change no-unused-vars 'args' from none to all to show warning on dest…

[goncy]

Issue: #4186

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[andriijas]

With argument destructing increasing in popularity this makes sense. Thanks

[Timer]

@andriijas please always tag a pull request and assign it to a milestone so we know what release it belongs in.

[andriijas]

This change has been reverted. I was under the impression this change only affected object destructing in arguments and after consideration among maintainers we decided to stick with the previous setting for now. Sorry about any inconvenience.

[NMinhNguyen]

@andriijas seeing as this has been reverted, do you think it's worth reverting https://github.com/facebook/create-react-app/pull/4193/files#diff-79a994d7bd8a0e363c3337f8c1bddc94R31 and https://github.com/facebook/create-react-app/pull/4193/files#diff-9cf9a22a4fe9ace4e45624edd93709c7R16 too? Personally, I think they were clearer/better that way (as in with the frames function argument and without the eslint-disable-line) 🙂

[Timer]

I think so @NMinhNguyen ! Can you send a PR reverting that?

[NMinhNguyen]

@Timer here you go! #4211