Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add create-react-app --help info for local file path --scripts-version support #4015

Merged
merged 4 commits into from
Mar 26, 2018

Conversation

albertstill
Copy link
Contributor

@albertstill albertstill commented Feb 12, 2018

I did not know the local file path feature existed for the scripts version until I looked at the source. It's very useful when testing a fork of react-scripts.

My PR simply adds another "can be one of" option when create-react-app --help is run. Now it looks like:

screen shot 2018-02-21 at 3 40 06 pm

e.g create-react-app --scripts-version file:../my-create-react-app-fork/packages/react-scripts my-app

@albertstill albertstill changed the title add create-react-app --help info for local file path --scripts-version support add create-react-app --help info for local file path --scripts-version support Feb 12, 2018
@iansu
Copy link
Contributor

iansu commented Feb 20, 2018

This seems like a good addition to me. I would suggest changing the example path to something like ../my-react-scripts so that it more closely matches the other examples.

@albertstill
Copy link
Contributor Author

Good point @iansu, done!

@albertstill
Copy link
Contributor Author

Any idea why AppVeyor is failing?

@albertstill
Copy link
Contributor Author

Merged in latest and it's green now @iansu

@Timer
Copy link
Contributor

Timer commented Mar 26, 2018

Thanks!

@Timer Timer added this to the 2.0.0 milestone Mar 26, 2018
@Timer Timer merged commit 06dd17e into facebook:next Mar 26, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants