Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable page reloading for files in public/ #1546

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Enable page reloading for files in public/ #1546

merged 1 commit into from
Feb 15, 2017

Conversation

SpaceK33z
Copy link
Contributor

@SpaceK33z SpaceK33z commented Feb 13, 2017 •
edited
Loading

This makes files in the public/ folder reload the page when they change.

Test plan:

  • create a project;
  • start the project with npm start;
  • modify something in public/index.html, for example the <title>;
  • hit save;
  • verify that the page has reloaded and the title has changed.

Fixes #656, fixes #1508

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

@SpaceK33z SpaceK33z mentioned this pull request Feb 13, 2017
Closed
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon added this to the 0.10.0 milestone Feb 13, 2017
@gaearon gaearon requested a review from Timer February 13, 2017 15:05
Timer
Timer approved these changes Feb 15, 2017
View reviewed changes
Copy link
Contributor

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, runs & works on my system and I am observing no additional CPU usage.

@Timer
Copy link
Contributor

Timer commented Feb 15, 2017

Thanks for acting so quick, @SpaceK33z!

@Timer Timer merged commit 1d5a277 into facebook:master Feb 15, 2017
danielfigueiredo pushed a commit to danielfigueiredo/create-react-app that referenced this pull request Feb 22, 2017
@SpaceK33z
Enable watchContentBase for webpack-dev-server (facebook#1546)
d0f8582 
Resolves facebook#1508
kst404 pushed a commit to kst404/e8e-react-scripts that referenced this pull request Mar 2, 2017
@SpaceK33z @Timer
Enable watchContentBase for webpack-dev-server (facebook#1546)
9bcd16a 
Resolves facebook#1508
SpaceK33z added a commit to CodeYellowBV/create-react-cy-app that referenced this pull request Mar 7, 2017
@SpaceK33z
Enable watchContentBase for webpack-dev-server (facebook#1546)
23e4fe0 
Resolves facebook#1508
# Conflicts:
#	packages/react-dev-utils/webpackHotDevClient.js
@lennerd lennerd mentioned this pull request Mar 17, 2017
Closed
@gaearon gaearon mentioned this pull request May 16, 2017
Closed
@gaearon
Copy link
Contributor

gaearon commented May 16, 2017

Please help beta test the new version that includes this change!
#2172

@SpaceK33z SpaceK33z deleted the watch-contentbase branch May 18, 2017 20:23
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
1.0.0
4 participants
@SpaceK33z @facebook-github-bot @Timer @gaearon