Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/Fix running-tests.md accuracy #11694

Closed
wants to merge 3 commits into from

Conversation

jayeclark
Copy link

@jayeclark jayeclark commented Nov 30, 2021

Signed-off-by: Jay Clark [email protected]

Fixes #11548

I came across issue #11548 and added a fix to make the docs match the current reality of src/App.test.js.

@jayeclark jayeclark requested a review from iansu as a code owner November 30, 2021 17:17
@facebook-github-bot
Copy link

Hi @jayeclark!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@jayeclark jayeclark changed the title Fix running-tests.md accuracy Docs/Fix running-tests.md accuracy Nov 30, 2021
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale
Copy link

stale bot commented Jan 8, 2022

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 8, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jayeclark jayeclark requested a review from mrmckeb as a code owner February 14, 2022 17:18
@stale stale bot removed the stale label Feb 14, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jayeclark jayeclark closed this Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs are outdated about initial App.test.js
2 participants