Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Y/n prompt (e.g. when ejecting) with a nice UI #1767

Closed
gaearon opened this issue Mar 8, 2017 · 4 comments
Closed

Replace Y/n prompt (e.g. when ejecting) with a nice UI #1767

gaearon opened this issue Mar 8, 2017 · 4 comments
Labels
contributions: claimed difficulty: starter tag: enhancement
Milestone
1.0.0

Comments

@gaearon
Copy link
Contributor

gaearon commented Mar 8, 2017

We have a custom prompt but it's not very pretty.
We should replace it with this library.

I think Lerna uses it, so you can look for examples in Lerna repo.
You can search source code for prompt to find our custom utility (that we should replace).
@iansu
Copy link
Contributor

iansu commented Mar 8, 2017

I'd like to take a look at this.

@Timer
Copy link
Contributor

Timer commented Mar 8, 2017

All yours!

@iansu
Copy link
Contributor

iansu commented Mar 9, 2017

PR #1772.

sbuzonas pushed a commit to sbuzonas/react-scripts that referenced this issue May 5, 2017
@dmr @gaearon
Add a note for OSX users about watchman and jest (facebook#1080)
c0666cf 
* Add a note for OSX users about watchman and jest

Minor additional information on how to solve watchman problems reported in facebook#713 and facebook#1767

* Introduced new Troubleshooting section

Add better explanation how to solve facebook#713 and linked related Issues.

* Tweak wording and add it to TOC
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this issue May 8, 2017
@dmr @randycoulman
Add a note for OSX users about watchman and jest (facebook#1080)
a43f722 
* Add a note for OSX users about watchman and jest

Minor additional information on how to solve watchman problems reported in facebook#713 and facebook#1767

* Introduced new Troubleshooting section

Add better explanation how to solve facebook#713 and linked related Issues.

* Tweak wording and add it to TOC
@gaearon
Copy link
Contributor Author

gaearon commented May 14, 2017

Fixed in #1772.

@gaearon gaearon closed this as completed May 14, 2017
@gaearon gaearon added this to the 0.10.0 milestone May 14, 2017
@dmr dmr mentioned this issue Dec 3, 2016
Merged
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
contributions: claimed difficulty: starter tag: enhancement
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@iansu @Timer @gaearon