-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aws_deploy npm action to build workflow #229
Conversation
Added the scripts/aws_deploy.py script which will run at the end of github builds and push stuff up to s3, so that you can easily get builds to reviewers or anyone else without issue. Needs to have some secrets set up on github to work, documentation is at the top of the python script.
c3b7179
to
fa94989
Compare
@vanreece I think I like the second log option, just purely from a forensics style 'crime scene' investigation. Good to have a manifest of what the job uploaded, as that would be useful to contrast vs. what's in a given directory at any point in time. |
Yeah, I'm with ya on that one. Will do. |
258e448
to
4f97cc0
Compare
This branch CAN actually be merged as it appears to work fine under other circumstances- the reason these builds are failing now is because by security policy, github secrets can't be accessed from PRs that originate from other forks! |
* Move CrossEditableZoom event firing. It should happen after projection is transformed. * Bump versions * Switch to Mapillary API v4 * Fix traffic sign rendering and geometry conversion * Remove debugging code * Update locale file * Removing redundant @mapbox/geojson-rewind dep pkg * Remove unused map feature title * Bring map map feature tooltips * Add missing mapillary map feature classes * Update translation file * Bing imagery - Ensure freshness * bingImagery strict n param. Fallback url tempalate to latest * minor revert catch log * some bing imagery docs comments * typo * Add aws_deploy npm action to build workflow (#229) * Add aws_deploy npm action to build workflow Added the scripts/aws_deploy.py script which will run at the end of github builds and push stuff up to s3, so that you can easily get builds to reviewers or anyone else without issue. Needs to have some secrets set up on github to work, documentation is at the top of the python script. * Hopefully more verbose logging when amazon fails * DO NOT MERGE: Adding hook for this branch to test on github * Better capture failure cases of aws calls * Going with the middle spam level for logging * Replace Rollup with Esbuild. (#246) * Add new esbuild-based quickstart directive. * Get the esbuild legacy build working, save for issues with NSI. * Upgrade several dependencies, bump minimum node version to 12 - country-coder (closes #249) - location-conflation (closes #248) - osm-community-index (closes #250) - name-suggestion-index * Bump marked from 2.0.7 to 2.1.2 Bumps [marked](https://github.com/markedjs/marked) from 2.0.7 to 2.1.2. - [Release notes](https://github.com/markedjs/marked/releases) - [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js) - [Commits](markedjs/marked@v2.0.7...v2.1.2) --- updated-dependencies: - dependency-name: marked dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Add the es5 directive back. * Get dev builds working once again, normal builds still slightly wonky. * Get some sort of legacy build working by converting requires() to import statements. * Fix target for esbuild legacy build * Move build all directive to use esbuild. * Add visualizer capability and build directive. * Remove rollup from dependency list completely! Co-authored-by: Bryan Housel <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove special case for push to deploy_with_action This was just used during development * Clean up log, and add link to build result * One too many slashes * Is this simple conditional good enough? * Better syntax? * Now with correct syntax * Bump osm-community-index from 5.0.1 to 5.1.0 Bumps [osm-community-index](https://github.com/osmlab/osm-community-index) from 5.0.1 to 5.1.0. - [Release notes](https://github.com/osmlab/osm-community-index/releases) - [Changelog](https://github.com/osmlab/osm-community-index/blob/main/CHANGELOG.md) - [Commits](osmlab/osm-community-index@v5.0.1...v5.1.0) --- updated-dependencies: - dependency-name: osm-community-index dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump osm-community-index from 5.0.1 to 5.1.0 * If locationSet is missing `include`, default to worldwide include openstreetmap/iD#8305 (comment) * pacify eslint, fix merge goof in map.js * Build sourcemap too * Use pagination to fetch all the esri datasets (closes #257) * Bump object-inspect from 1.10.3 to 1.11.0 Bumps [object-inspect](https://github.com/inspect-js/object-inspect) from 1.10.3 to 1.11.0. - [Release notes](https://github.com/inspect-js/object-inspect/releases) - [Commits](inspect-js/object-inspect@v1.10.3...v1.11.0) --- updated-dependencies: - dependency-name: object-inspect dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * gitignore esbuild.json It changes on every build and is only use to rebuild the stats * Bump osm-community-index to 5.1.1 * Modernize more scripts (convert require to import) * npm run imagery * npm run translations * rapid-v1.1.5 * Set z-index of absolutely positioned layers under supersurface Each of these has their own internal stacking context * npm run translations * Fix link * Math/extent conversion (#272) * Bump version to newest id-sdk release. * Convert geoExtent to id-sdk/Extent. Most tests working. * Fix remaining tests. * Remove geo modules no longer in use. * Revert "Fix remaining tests." This reverts commit 7ba89ce. * Fix a number of instances of extents being used as raw tuples. * Woops- converted zoom/pan functionality that interacts with d3. NOT a candidate for Extent() conversion. * Fix roads/ways not appearing in the map, also fix a crossing ways test problem. * Fix an issue with the measurement panel not setting its extent correctly. * fix usages of Extend.extend() because it no longer modifies the extent in-place. * Fix copy / paste bug that falsely claimed everything had an extent of +/- Infinity. * add service module for querying streetview suggestions (#192) * Show suggestion images and viewfield icon * fix PR comments * hightlight images and viewfields on hover * Sort images by increasing longitude, so that the left-rightness of images matches the flow of the map points as we scan left->right. * Add image strip as separate component (still quite buggy). Fix the two-way binding between image fields and images in the strip so that hover/select highlights correctly. * Fix the image filmstrip so that it is properly shut off / redisplayed as the user hovers over / moves off a sidewalk. * Fix bug that was selecting the wrong service when we selected a sidewalk suggestion. * Get image strip working with Bryan's help. * Fix sorting of images by longitude. * Improve styling of the image strip, and add 'enlarge on mouse hover' interaction. * style suggested sidewalks * Parse crosswalk data * remove console.log statement * Fix debug messages that shouldn't have been checked in. * Fix issue that was causing too many viewfield nodes to appear. * fix hovering issues * Fix some linter errors. * Make 5 images not require a scrollbar in the image strip, even when one is zoomed. * Fix images to all have the same height, not the same width. * Fix code drift issues that had occurred in main. Co-authored-by: Milos Brzakovic (E-Search) <[email protected]> Co-authored-by: Bryan Housel <[email protected]> Co-authored-by: Nikola Pleša <[email protected]> Co-authored-by: Milos Brzakovic <[email protected]> Co-authored-by: Danny Krause <[email protected]> Co-authored-by: Ben Clark <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xiaoming Gao <[email protected]> Co-authored-by: Amol Vasant Khadilkar <[email protected]> Co-authored-by: Benjamin Clark <[email protected]>
* Move CrossEditableZoom event firing. It should happen after projection is transformed. * Bump versions * Switch to Mapillary API v4 * Fix traffic sign rendering and geometry conversion * Remove debugging code * Update locale file * Removing redundant @mapbox/geojson-rewind dep pkg * Remove unused map feature title * Bring map map feature tooltips * Add missing mapillary map feature classes * Update translation file * Bing imagery - Ensure freshness * bingImagery strict n param. Fallback url tempalate to latest * minor revert catch log * some bing imagery docs comments * typo * Add aws_deploy npm action to build workflow (#229) * Add aws_deploy npm action to build workflow Added the scripts/aws_deploy.py script which will run at the end of github builds and push stuff up to s3, so that you can easily get builds to reviewers or anyone else without issue. Needs to have some secrets set up on github to work, documentation is at the top of the python script. * Hopefully more verbose logging when amazon fails * DO NOT MERGE: Adding hook for this branch to test on github * Better capture failure cases of aws calls * Going with the middle spam level for logging * Replace Rollup with Esbuild. (#246) * Add new esbuild-based quickstart directive. * Get the esbuild legacy build working, save for issues with NSI. * Upgrade several dependencies, bump minimum node version to 12 - country-coder (closes #249) - location-conflation (closes #248) - osm-community-index (closes #250) - name-suggestion-index * Bump marked from 2.0.7 to 2.1.2 Bumps [marked](https://github.com/markedjs/marked) from 2.0.7 to 2.1.2. - [Release notes](https://github.com/markedjs/marked/releases) - [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js) - [Commits](markedjs/marked@v2.0.7...v2.1.2) --- updated-dependencies: - dependency-name: marked dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Add the es5 directive back. * Get dev builds working once again, normal builds still slightly wonky. * Get some sort of legacy build working by converting requires() to import statements. * Fix target for esbuild legacy build * Move build all directive to use esbuild. * Add visualizer capability and build directive. * Remove rollup from dependency list completely! Co-authored-by: Bryan Housel <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove special case for push to deploy_with_action This was just used during development * Clean up log, and add link to build result * One too many slashes * Is this simple conditional good enough? * Better syntax? * Now with correct syntax * Bump osm-community-index from 5.0.1 to 5.1.0 Bumps [osm-community-index](https://github.com/osmlab/osm-community-index) from 5.0.1 to 5.1.0. - [Release notes](https://github.com/osmlab/osm-community-index/releases) - [Changelog](https://github.com/osmlab/osm-community-index/blob/main/CHANGELOG.md) - [Commits](osmlab/osm-community-index@v5.0.1...v5.1.0) --- updated-dependencies: - dependency-name: osm-community-index dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump osm-community-index from 5.0.1 to 5.1.0 * If locationSet is missing `include`, default to worldwide include openstreetmap/iD#8305 (comment) * pacify eslint, fix merge goof in map.js * Build sourcemap too * Use pagination to fetch all the esri datasets (closes #257) * Bump object-inspect from 1.10.3 to 1.11.0 Bumps [object-inspect](https://github.com/inspect-js/object-inspect) from 1.10.3 to 1.11.0. - [Release notes](https://github.com/inspect-js/object-inspect/releases) - [Commits](inspect-js/object-inspect@v1.10.3...v1.11.0) --- updated-dependencies: - dependency-name: object-inspect dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * gitignore esbuild.json It changes on every build and is only use to rebuild the stats * Bump osm-community-index to 5.1.1 * Modernize more scripts (convert require to import) * npm run imagery * npm run translations * rapid-v1.1.5 * Set z-index of absolutely positioned layers under supersurface Each of these has their own internal stacking context * npm run translations * Fix link * Math/extent conversion (#272) * Bump version to newest id-sdk release. * Convert geoExtent to id-sdk/Extent. Most tests working. * Fix remaining tests. * Remove geo modules no longer in use. * Revert "Fix remaining tests." This reverts commit 7ba89ce. * Fix a number of instances of extents being used as raw tuples. * Woops- converted zoom/pan functionality that interacts with d3. NOT a candidate for Extent() conversion. * Fix roads/ways not appearing in the map, also fix a crossing ways test problem. * Fix an issue with the measurement panel not setting its extent correctly. * fix usages of Extend.extend() because it no longer modifies the extent in-place. * Fix copy / paste bug that falsely claimed everything had an extent of +/- Infinity. * add service module for querying streetview suggestions (#192) * Show suggestion images and viewfield icon * fix PR comments * hightlight images and viewfields on hover * Sort images by increasing longitude, so that the left-rightness of images matches the flow of the map points as we scan left->right. * Add image strip as separate component (still quite buggy). Fix the two-way binding between image fields and images in the strip so that hover/select highlights correctly. * Fix the image filmstrip so that it is properly shut off / redisplayed as the user hovers over / moves off a sidewalk. * Fix bug that was selecting the wrong service when we selected a sidewalk suggestion. * Get image strip working with Bryan's help. * Fix sorting of images by longitude. * Improve styling of the image strip, and add 'enlarge on mouse hover' interaction. * style suggested sidewalks * Parse crosswalk data * remove console.log statement * Fix debug messages that shouldn't have been checked in. * Fix issue that was causing too many viewfield nodes to appear. * fix hovering issues * Fix some linter errors. * Make 5 images not require a scrollbar in the image strip, even when one is zoomed. * Fix images to all have the same height, not the same width. * Fix code drift issues that had occurred in main. Co-authored-by: Milos Brzakovic (E-Search) <[email protected]> Co-authored-by: Bryan Housel <[email protected]> Co-authored-by: Nikola Pleša <[email protected]> Co-authored-by: Milos Brzakovic <[email protected]> Co-authored-by: Danny Krause <[email protected]> Co-authored-by: Ben Clark <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xiaoming Gao <[email protected]> Co-authored-by: Amol Vasant Khadilkar <[email protected]> Co-authored-by: Benjamin Clark <[email protected]>
* Move CrossEditableZoom event firing. It should happen after projection is transformed. * Bump versions * Switch to Mapillary API v4 * Fix traffic sign rendering and geometry conversion * Remove debugging code * Update locale file * Removing redundant @mapbox/geojson-rewind dep pkg * Remove unused map feature title * Bring map map feature tooltips * Add missing mapillary map feature classes * Update translation file * Bing imagery - Ensure freshness * bingImagery strict n param. Fallback url tempalate to latest * minor revert catch log * some bing imagery docs comments * typo * Add aws_deploy npm action to build workflow (#229) * Add aws_deploy npm action to build workflow Added the scripts/aws_deploy.py script which will run at the end of github builds and push stuff up to s3, so that you can easily get builds to reviewers or anyone else without issue. Needs to have some secrets set up on github to work, documentation is at the top of the python script. * Hopefully more verbose logging when amazon fails * DO NOT MERGE: Adding hook for this branch to test on github * Better capture failure cases of aws calls * Going with the middle spam level for logging * Replace Rollup with Esbuild. (#246) * Add new esbuild-based quickstart directive. * Get the esbuild legacy build working, save for issues with NSI. * Upgrade several dependencies, bump minimum node version to 12 - country-coder (closes #249) - location-conflation (closes #248) - osm-community-index (closes #250) - name-suggestion-index * Bump marked from 2.0.7 to 2.1.2 Bumps [marked](https://github.com/markedjs/marked) from 2.0.7 to 2.1.2. - [Release notes](https://github.com/markedjs/marked/releases) - [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js) - [Commits](markedjs/marked@v2.0.7...v2.1.2) --- updated-dependencies: - dependency-name: marked dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Add the es5 directive back. * Get dev builds working once again, normal builds still slightly wonky. * Get some sort of legacy build working by converting requires() to import statements. * Fix target for esbuild legacy build * Move build all directive to use esbuild. * Add visualizer capability and build directive. * Remove rollup from dependency list completely! Co-authored-by: Bryan Housel <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove special case for push to deploy_with_action This was just used during development * Clean up log, and add link to build result * One too many slashes * Is this simple conditional good enough? * Better syntax? * Now with correct syntax * Bump osm-community-index from 5.0.1 to 5.1.0 Bumps [osm-community-index](https://github.com/osmlab/osm-community-index) from 5.0.1 to 5.1.0. - [Release notes](https://github.com/osmlab/osm-community-index/releases) - [Changelog](https://github.com/osmlab/osm-community-index/blob/main/CHANGELOG.md) - [Commits](osmlab/osm-community-index@v5.0.1...v5.1.0) --- updated-dependencies: - dependency-name: osm-community-index dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump osm-community-index from 5.0.1 to 5.1.0 * If locationSet is missing `include`, default to worldwide include openstreetmap/iD#8305 (comment) * pacify eslint, fix merge goof in map.js * Build sourcemap too * Use pagination to fetch all the esri datasets (closes #257) * Bump object-inspect from 1.10.3 to 1.11.0 Bumps [object-inspect](https://github.com/inspect-js/object-inspect) from 1.10.3 to 1.11.0. - [Release notes](https://github.com/inspect-js/object-inspect/releases) - [Commits](inspect-js/object-inspect@v1.10.3...v1.11.0) --- updated-dependencies: - dependency-name: object-inspect dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * gitignore esbuild.json It changes on every build and is only use to rebuild the stats * Bump osm-community-index to 5.1.1 * Modernize more scripts (convert require to import) * npm run imagery * npm run translations * rapid-v1.1.5 * Set z-index of absolutely positioned layers under supersurface Each of these has their own internal stacking context * npm run translations * Fix link * Math/extent conversion (#272) * Bump version to newest id-sdk release. * Convert geoExtent to id-sdk/Extent. Most tests working. * Fix remaining tests. * Remove geo modules no longer in use. * Revert "Fix remaining tests." This reverts commit 7ba89ce. * Fix a number of instances of extents being used as raw tuples. * Woops- converted zoom/pan functionality that interacts with d3. NOT a candidate for Extent() conversion. * Fix roads/ways not appearing in the map, also fix a crossing ways test problem. * Fix an issue with the measurement panel not setting its extent correctly. * fix usages of Extend.extend() because it no longer modifies the extent in-place. * Fix copy / paste bug that falsely claimed everything had an extent of +/- Infinity. * add service module for querying streetview suggestions (#192) * Show suggestion images and viewfield icon * fix PR comments * hightlight images and viewfields on hover * Sort images by increasing longitude, so that the left-rightness of images matches the flow of the map points as we scan left->right. * Add image strip as separate component (still quite buggy). Fix the two-way binding between image fields and images in the strip so that hover/select highlights correctly. * Fix the image filmstrip so that it is properly shut off / redisplayed as the user hovers over / moves off a sidewalk. * Fix bug that was selecting the wrong service when we selected a sidewalk suggestion. * Get image strip working with Bryan's help. * Fix sorting of images by longitude. * Improve styling of the image strip, and add 'enlarge on mouse hover' interaction. * style suggested sidewalks * Parse crosswalk data * remove console.log statement * Fix debug messages that shouldn't have been checked in. * Fix issue that was causing too many viewfield nodes to appear. * fix hovering issues * Fix some linter errors. * Make 5 images not require a scrollbar in the image strip, even when one is zoomed. * Fix images to all have the same height, not the same width. * Fix code drift issues that had occurred in main. Co-authored-by: Milos Brzakovic (E-Search) <[email protected]> Co-authored-by: Bryan Housel <[email protected]> Co-authored-by: Nikola Pleša <[email protected]> Co-authored-by: Milos Brzakovic <[email protected]> Co-authored-by: Danny Krause <[email protected]> Co-authored-by: Ben Clark <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xiaoming Gao <[email protected]> Co-authored-by: Amol Vasant Khadilkar <[email protected]> Co-authored-by: Benjamin Clark <[email protected]>
* Move CrossEditableZoom event firing. It should happen after projection is transformed. * Bump versions * Switch to Mapillary API v4 * Fix traffic sign rendering and geometry conversion * Remove debugging code * Update locale file * Removing redundant @mapbox/geojson-rewind dep pkg * Remove unused map feature title * Bring map map feature tooltips * Add missing mapillary map feature classes * Update translation file * Bing imagery - Ensure freshness * bingImagery strict n param. Fallback url tempalate to latest * minor revert catch log * some bing imagery docs comments * typo * Add aws_deploy npm action to build workflow (#229) * Add aws_deploy npm action to build workflow Added the scripts/aws_deploy.py script which will run at the end of github builds and push stuff up to s3, so that you can easily get builds to reviewers or anyone else without issue. Needs to have some secrets set up on github to work, documentation is at the top of the python script. * Hopefully more verbose logging when amazon fails * DO NOT MERGE: Adding hook for this branch to test on github * Better capture failure cases of aws calls * Going with the middle spam level for logging * Replace Rollup with Esbuild. (#246) * Add new esbuild-based quickstart directive. * Get the esbuild legacy build working, save for issues with NSI. * Upgrade several dependencies, bump minimum node version to 12 - country-coder (closes #249) - location-conflation (closes #248) - osm-community-index (closes #250) - name-suggestion-index * Bump marked from 2.0.7 to 2.1.2 Bumps [marked](https://github.com/markedjs/marked) from 2.0.7 to 2.1.2. - [Release notes](https://github.com/markedjs/marked/releases) - [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js) - [Commits](markedjs/marked@v2.0.7...v2.1.2) --- updated-dependencies: - dependency-name: marked dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Add the es5 directive back. * Get dev builds working once again, normal builds still slightly wonky. * Get some sort of legacy build working by converting requires() to import statements. * Fix target for esbuild legacy build * Move build all directive to use esbuild. * Add visualizer capability and build directive. * Remove rollup from dependency list completely! Co-authored-by: Bryan Housel <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove special case for push to deploy_with_action This was just used during development * Clean up log, and add link to build result * One too many slashes * Is this simple conditional good enough? * Better syntax? * Now with correct syntax * Bump osm-community-index from 5.0.1 to 5.1.0 Bumps [osm-community-index](https://github.com/osmlab/osm-community-index) from 5.0.1 to 5.1.0. - [Release notes](https://github.com/osmlab/osm-community-index/releases) - [Changelog](https://github.com/osmlab/osm-community-index/blob/main/CHANGELOG.md) - [Commits](osmlab/osm-community-index@v5.0.1...v5.1.0) --- updated-dependencies: - dependency-name: osm-community-index dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump osm-community-index from 5.0.1 to 5.1.0 * If locationSet is missing `include`, default to worldwide include openstreetmap/iD#8305 (comment) * pacify eslint, fix merge goof in map.js * Build sourcemap too * Use pagination to fetch all the esri datasets (closes #257) * Bump object-inspect from 1.10.3 to 1.11.0 Bumps [object-inspect](https://github.com/inspect-js/object-inspect) from 1.10.3 to 1.11.0. - [Release notes](https://github.com/inspect-js/object-inspect/releases) - [Commits](inspect-js/object-inspect@v1.10.3...v1.11.0) --- updated-dependencies: - dependency-name: object-inspect dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * gitignore esbuild.json It changes on every build and is only use to rebuild the stats * Bump osm-community-index to 5.1.1 * Modernize more scripts (convert require to import) * npm run imagery * npm run translations * rapid-v1.1.5 * Set z-index of absolutely positioned layers under supersurface Each of these has their own internal stacking context * npm run translations * Fix link * Math/extent conversion (#272) * Bump version to newest id-sdk release. * Convert geoExtent to id-sdk/Extent. Most tests working. * Fix remaining tests. * Remove geo modules no longer in use. * Revert "Fix remaining tests." This reverts commit 7ba89ce. * Fix a number of instances of extents being used as raw tuples. * Woops- converted zoom/pan functionality that interacts with d3. NOT a candidate for Extent() conversion. * Fix roads/ways not appearing in the map, also fix a crossing ways test problem. * Fix an issue with the measurement panel not setting its extent correctly. * fix usages of Extend.extend() because it no longer modifies the extent in-place. * Fix copy / paste bug that falsely claimed everything had an extent of +/- Infinity. * add service module for querying streetview suggestions (#192) * Show suggestion images and viewfield icon * fix PR comments * hightlight images and viewfields on hover * Sort images by increasing longitude, so that the left-rightness of images matches the flow of the map points as we scan left->right. * Add image strip as separate component (still quite buggy). Fix the two-way binding between image fields and images in the strip so that hover/select highlights correctly. * Fix the image filmstrip so that it is properly shut off / redisplayed as the user hovers over / moves off a sidewalk. * Fix bug that was selecting the wrong service when we selected a sidewalk suggestion. * Get image strip working with Bryan's help. * Fix sorting of images by longitude. * Improve styling of the image strip, and add 'enlarge on mouse hover' interaction. * style suggested sidewalks * Parse crosswalk data * remove console.log statement * Fix debug messages that shouldn't have been checked in. * Fix issue that was causing too many viewfield nodes to appear. * fix hovering issues * Fix some linter errors. * Make 5 images not require a scrollbar in the image strip, even when one is zoomed. * Fix images to all have the same height, not the same width. * Fix code drift issues that had occurred in main. Co-authored-by: Milos Brzakovic (E-Search) <[email protected]> Co-authored-by: Bryan Housel <[email protected]> Co-authored-by: Nikola Pleša <[email protected]> Co-authored-by: Milos Brzakovic <[email protected]> Co-authored-by: Danny Krause <[email protected]> Co-authored-by: Ben Clark <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xiaoming Gao <[email protected]> Co-authored-by: Amol Vasant Khadilkar <[email protected]> Co-authored-by: Benjamin Clark <[email protected]>
* Move CrossEditableZoom event firing. It should happen after projection is transformed. * Bump versions * Switch to Mapillary API v4 * Fix traffic sign rendering and geometry conversion * Remove debugging code * Update locale file * Removing redundant @mapbox/geojson-rewind dep pkg * Remove unused map feature title * Bring map map feature tooltips * Add missing mapillary map feature classes * Update translation file * Bing imagery - Ensure freshness * bingImagery strict n param. Fallback url tempalate to latest * minor revert catch log * some bing imagery docs comments * typo * Add aws_deploy npm action to build workflow (#229) * Add aws_deploy npm action to build workflow Added the scripts/aws_deploy.py script which will run at the end of github builds and push stuff up to s3, so that you can easily get builds to reviewers or anyone else without issue. Needs to have some secrets set up on github to work, documentation is at the top of the python script. * Hopefully more verbose logging when amazon fails * DO NOT MERGE: Adding hook for this branch to test on github * Better capture failure cases of aws calls * Going with the middle spam level for logging * Replace Rollup with Esbuild. (#246) * Add new esbuild-based quickstart directive. * Get the esbuild legacy build working, save for issues with NSI. * Upgrade several dependencies, bump minimum node version to 12 - country-coder (closes #249) - location-conflation (closes #248) - osm-community-index (closes #250) - name-suggestion-index * Bump marked from 2.0.7 to 2.1.2 Bumps [marked](https://github.com/markedjs/marked) from 2.0.7 to 2.1.2. - [Release notes](https://github.com/markedjs/marked/releases) - [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js) - [Commits](markedjs/marked@v2.0.7...v2.1.2) --- updated-dependencies: - dependency-name: marked dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Add the es5 directive back. * Get dev builds working once again, normal builds still slightly wonky. * Get some sort of legacy build working by converting requires() to import statements. * Fix target for esbuild legacy build * Move build all directive to use esbuild. * Add visualizer capability and build directive. * Remove rollup from dependency list completely! Co-authored-by: Bryan Housel <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove special case for push to deploy_with_action This was just used during development * Clean up log, and add link to build result * One too many slashes * Is this simple conditional good enough? * Better syntax? * Now with correct syntax * Bump osm-community-index from 5.0.1 to 5.1.0 Bumps [osm-community-index](https://github.com/osmlab/osm-community-index) from 5.0.1 to 5.1.0. - [Release notes](https://github.com/osmlab/osm-community-index/releases) - [Changelog](https://github.com/osmlab/osm-community-index/blob/main/CHANGELOG.md) - [Commits](osmlab/osm-community-index@v5.0.1...v5.1.0) --- updated-dependencies: - dependency-name: osm-community-index dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump osm-community-index from 5.0.1 to 5.1.0 * If locationSet is missing `include`, default to worldwide include openstreetmap/iD#8305 (comment) * pacify eslint, fix merge goof in map.js * Build sourcemap too * Use pagination to fetch all the esri datasets (closes #257) * Bump object-inspect from 1.10.3 to 1.11.0 Bumps [object-inspect](https://github.com/inspect-js/object-inspect) from 1.10.3 to 1.11.0. - [Release notes](https://github.com/inspect-js/object-inspect/releases) - [Commits](inspect-js/object-inspect@v1.10.3...v1.11.0) --- updated-dependencies: - dependency-name: object-inspect dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * gitignore esbuild.json It changes on every build and is only use to rebuild the stats * Bump osm-community-index to 5.1.1 * Modernize more scripts (convert require to import) * npm run imagery * npm run translations * rapid-v1.1.5 * Set z-index of absolutely positioned layers under supersurface Each of these has their own internal stacking context * npm run translations * Fix link * Math/extent conversion (#272) * Bump version to newest id-sdk release. * Convert geoExtent to id-sdk/Extent. Most tests working. * Fix remaining tests. * Remove geo modules no longer in use. * Revert "Fix remaining tests." This reverts commit 7ba89ce. * Fix a number of instances of extents being used as raw tuples. * Woops- converted zoom/pan functionality that interacts with d3. NOT a candidate for Extent() conversion. * Fix roads/ways not appearing in the map, also fix a crossing ways test problem. * Fix an issue with the measurement panel not setting its extent correctly. * fix usages of Extend.extend() because it no longer modifies the extent in-place. * Fix copy / paste bug that falsely claimed everything had an extent of +/- Infinity. * add service module for querying streetview suggestions (#192) * Show suggestion images and viewfield icon * fix PR comments * hightlight images and viewfields on hover * Sort images by increasing longitude, so that the left-rightness of images matches the flow of the map points as we scan left->right. * Add image strip as separate component (still quite buggy). Fix the two-way binding between image fields and images in the strip so that hover/select highlights correctly. * Fix the image filmstrip so that it is properly shut off / redisplayed as the user hovers over / moves off a sidewalk. * Fix bug that was selecting the wrong service when we selected a sidewalk suggestion. * Get image strip working with Bryan's help. * Fix sorting of images by longitude. * Improve styling of the image strip, and add 'enlarge on mouse hover' interaction. * style suggested sidewalks * Parse crosswalk data * remove console.log statement * Fix debug messages that shouldn't have been checked in. * Fix issue that was causing too many viewfield nodes to appear. * fix hovering issues * Fix some linter errors. * Make 5 images not require a scrollbar in the image strip, even when one is zoomed. * Fix images to all have the same height, not the same width. * Fix code drift issues that had occurred in main. Co-authored-by: Milos Brzakovic (E-Search) <[email protected]> Co-authored-by: Bryan Housel <[email protected]> Co-authored-by: Nikola Pleša <[email protected]> Co-authored-by: Milos Brzakovic <[email protected]> Co-authored-by: Danny Krause <[email protected]> Co-authored-by: Ben Clark <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xiaoming Gao <[email protected]> Co-authored-by: Amol Vasant Khadilkar <[email protected]> Co-authored-by: Benjamin Clark <[email protected]>
Added the scripts/aws_deploy.py script which will run at the end of
github builds and push stuff up to s3, so that you can easily get builds
to reviewers or anyone else without issue.
Needs to have some secrets set up on github to work, documentation is at
the top of the python script.
Of note, currently the --quiet flag is passed to the aws commands, resulting in a less spammy view in the actions log, but, there's three options I considered, and I'm laying them out below:
Full spam (not recommended, showing partial upload info) is here: https://github.com/vanreece/RapiD/runs/2741023491?check_suite_focus=true
--no-progress still shows each file uploaded, but not partial progress: https://github.com/vanreece/RapiD/runs/2766195986?check_suite_focus=true
--quiet doesn't talk at all about individually uploaded files, minimum log spam (current setting): https://github.com/vanreece/RapiD/runs/2766275985?check_suite_focus=true
What do y'all think about those three options?