Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add service module for querying streetview suggestions #192

Merged
merged 3 commits into from
Dec 16, 2020
Merged

add service module for querying streetview suggestions #192

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9656d8c
add service module for querying streetview suggestions
Dec 15, 2020
505b0f1
fix review comments in PR #192
Dec 15, 2020
2b4197a
address review comments and update API to mapwith.ai
Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion data/core.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,6 +990,9 @@ en:
msBuildings:
label: Microsoft Buildings
license_markdown: "[license](https://github.com/microsoft/USBuildingFootprints/blob/master/LICENCE-DATA)"
fbSidewalks:
label: Facebook Sidewalk Suggestions
license_markdown: "[license](https://mapwith.ai/doc/license/MapWithAILicense.pdf)"
esri:
title: ArcGIS Datasets
about: "These datasets have been provided as open data by the ArcGIS user community for the purpose of improving OpenStreetMap.<br/>You can learn more by visiting [the RapiD Guide](https://github.com/facebookmicrosites/Open-Mapping-At-Facebook/wiki/Esri-ArcGIS-FAQ) or [Esri/ArcGIS dataset page on the OSM Wiki](https://wiki.openstreetmap.org/wiki/Esri/ArcGIS_Datasets)."
Expand Down Expand Up @@ -2361,4 +2364,4 @@ en:
wikidata:
identifier: "Identifier"
label: "Label"
description: "Description"
description: "Description"
13 changes: 5 additions & 8 deletions dist/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1237,6 +1237,10 @@
"label": "Microsoft Buildings",
"license_markdown": "[license](https://github.com/microsoft/USBuildingFootprints/blob/master/LICENCE-DATA)"
},
"fbSidewalks": {
"label": "Facebook Sidewalk Suggestions",
"license_markdown": "[license](https://mapwith.ai/doc/license/MapWithAILicense.pdf)"
},
"esri": {
"title": "ArcGIS Datasets",
"about": "These datasets have been provided as open data by the ArcGIS user community for the purpose of improving OpenStreetMap.<br/>You can learn more by visiting [the RapiD Guide](https://github.com/facebookmicrosites/Open-Mapping-At-Facebook/wiki/Esri-ArcGIS-FAQ) or [Esri/ArcGIS dataset page on the OSM Wiki](https://wiki.openstreetmap.org/wiki/Esri/ArcGIS_Datasets).",
Expand Down Expand Up @@ -10879,7 +10883,7 @@
"attribution": {
"text": "GSI KIBAN 2500"
},
"description": "GSI Kiban 2500 via aginfo.cgk.affrc.go.jp. Good for tracing, but a bit older.",
"description": "GSI Kiban 2500 via finds.jp. Good for tracing, but a bit older.",
"name": "Japan GSI KIBAN 2500"
},
"gothenburg-citymap": {
Expand Down Expand Up @@ -11072,13 +11076,6 @@
"description": "Orthophotos from the municipality of Stockholm 2016, CC0 license",
"name": "Stockholm Orthophoto"
},
"susono_shizuoka_jp_orthophoto": {
"attribution": {
"text": "Susono city orthophoto"
},
"description": "The aerial photos released by Susono City as open data.",
"name": "Susono city orthophoto"
},
"tf-cycle": {
"attribution": {
"text": "Maps © Thunderforest, Data © OpenStreetMap contributors"
Expand Down
15 changes: 13 additions & 2 deletions modules/core/rapid_context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export function coreRapidContext(context) {
id: 'fbRoads',
beta: false,
added: true, // whether it should appear in the list
enabled: true, // whether the user has checked it on
enabled: false, // whether the user has checked it on
conflated: true,
service: 'fbml',
color: RAPID_MAGENTA,
Expand All @@ -121,12 +121,23 @@ export function coreRapidContext(context) {
id: 'msBuildings',
beta: false,
added: true, // whether it should appear in the list
enabled: true, // whether the user has checked it on
enabled: false, // whether the user has checked it on
conflated: true,
service: 'fbml',
color: RAPID_MAGENTA,
label: t('rapid_feature_toggle.msBuildings.label'),
license_markdown: t('rapid_feature_toggle.msBuildings.license_markdown')
},
gaoxm marked this conversation as resolved.
Show resolved Hide resolved
'fbSidewalks': {
id: 'fbSidewalks',
beta: true,
added: true, // whether it should appear in the list
enabled: true, // whether the user has checked it on
conflated: true,
service: 'fbml_streetview',
color: RAPID_MAGENTA,
label: t('rapid_feature_toggle.fbSidewalks.label'),
license_markdown: t('rapid_feature_toggle.fbSidewalks.license_markdown')
}
};
});
Expand Down
Loading