Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar fixes #1497

Merged
merged 12 commits into from
Jul 31, 2024
Merged

Sidebar fixes #1497

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
eaf87eb
WIP on cleaning up sidebar code, start modernizing
bhousel Jul 22, 2024
ca501d2
Add 'not_dead' to browserslist to remove Internet Explorer
bhousel Jul 23, 2024
9a3c18e
WIP on making the sidebar content flexbox and modern
bhousel Jul 23, 2024
e021533
Switch sidebar and inspector to class components, use flexbox
bhousel Jul 25, 2024
75ff758
Fix sidebar interactivity and other changes
bhousel Jul 26, 2024
0726a3e
Improve sidebar resizer style, fix issues pane slide in-out
bhousel Jul 26, 2024
a9ae8e4
Fix sidebar RTL
bhousel Jul 26, 2024
4e1fc9f
Fix several other RTL issues
bhousel Jul 26, 2024
2d31a37
WIP on improving how resizing the window and sidebar works
bhousel Jul 29, 2024
79b54e2
Finally happy with the resizing behavior
bhousel Jul 30, 2024
91f0edf
Move resize from APP to DRAW
bhousel Jul 31, 2024
dc70a80
Remove sidebar toggle button, move tooltip to resizer
bhousel Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
608 changes: 307 additions & 301 deletions css/80_app.css
View file
Open in desktop

Large diffs are not rendered by default.

145 changes: 69 additions & 76 deletions css/80_app_fb.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,133 +194,126 @@ button.bugnub {


/* Sidebar - Rapid Inspector */
.rapid-inspector > div {
/* background: #222; */
/* color: #ddd; */
}

.rapid-inspector svg.logo-rapid {
height: 35px;
.rapid-inspector {
display: flex;
flex: 1 1 0px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

flex-flow: column nowrap;
}

.rapid-inspector .header {
/* background: #222; */
/* color: #fff; */
background: #f6f6f6;
color: #333;
border-bottom: 1px solid #aaaa;
flex: 0 0 0px;
background: #f6f6f6;
color: #333;
border-bottom: 1px solid #aaaa;
}
.rapid-inspector .header h3 {
display: flex;
display: flex;
}
.rapid-inspector .header svg.logo-rapid {
height: 35px;
}

.rapid-inspector .header button.rapid-inspector-close {
position: absolute;
top: 0;
right: 0;
background: transparent;
position: absolute;
top: 0;
right: 0;
background: transparent;
}
.ideditor[dir='rtl'] .rapid-inspector .header button.rapid-inspector-close {
right: unset;
left: 0;
right: unset;
left: 0;
}
.rapid-inspector .header button.rapid-inspector-close svg {
color: #da26d3;
color: #da26d3;
}
.rapid-inspector .header button.rapid-inspector-close:hover {
background: #8885;
background: #8885;
}

.rapid-inspector .tooltip .popover-inner {
border: 1px solid #aaaa;
}

.rapid-inspector-fadein .rapid-inspector .body {
animation: fadein 0s .25s forwards;
.rapid-inspector .tooltip .popover-inner {
border: 1px solid #aaaa;
}

.rapid-inspector .body {
/* background: #222; */
/* color: #ddd; */
background: #f6f6f6;
color: #333;
padding: 20px;
opacity: 1;
}
display: flex;
flex: 1 1 0px;
flex-flow: column nowrap;

@keyframes fadein {
from { opacity: 0 }
to { opacity: 1 }
background: #f6f6f6;
color: #333;
padding: 20px;
opacity: 1;
}


.rapid-inspector .body p {
padding: 20px 0;
padding: 20px 0;
}

.rapid-inspector .feature-info {
display: flex;
padding: 5px 10px;
border-radius: 5px 5px 0 0;
border: 1px solid #333;
display: flex;
padding: 5px 10px;
border-radius: 5px 5px 0 0;
border: 1px solid #333;
}

.rapid-inspector .feature-info .dataset-label {
flex: 1;
font-size: 14px;
font-weight: bold;
flex: 1;
font-size: 14px;
font-weight: bold;
}
.rapid-inspector .feature-info .dataset-beta {
font-size: 13px;
font-size: 13px;
}

.rapid-inspector .tag-info {
padding: 7px;
background: #444;
color: #ddd;
border-radius: 0 0 5px 5px;
border: 1px transparent;
padding: 7px;
background: #444;
color: #ddd;
border-radius: 0 0 5px 5px;
border: 1px transparent;
}
.rapid-inspector .tag-bag {
display: flex;
flex-wrap: wrap;
display: flex;
flex-flow: row wrap;
}
.rapid-inspector .tag-heading {
margin-right: 5px;
padding-left: 3px;
margin-right: 5px;
padding-left: 3px;
}
.rapid-inspector .tag-info .tag-entry {
flex: 0 1 auto;
display: flex;
border: 1px solid #aaaa;
border-radius: 5px;
font-size: smaller;
font-weight: 300;
margin: 0 3px;
display: flex;
flex: 0 1 auto;

border: 1px solid #aaaa;
border-radius: 5px;
font-size: smaller;
font-weight: 300;
margin: 0 3px;
}
.rapid-inspector .tag-key,
.rapid-inspector .tag-value {
flex: 0 1 auto;
padding: 0px 3px;
flex: 0 1 auto;
padding: 0px 3px;
}
.rapid-inspector .tag-key {
font-weight: bold;
font-size: unset;
font-weight: bold;
font-size: unset;
}

.rapid-inspector-choices {
display: flex;
flex-flow: column nowrap;
text-align: center;
background: linear-gradient(to top left, #ccc, #eee 90%);
border-radius: 5px;
display: flex;
flex-flow: column nowrap;
text-align: center;

background: linear-gradient(to top left, #ccc, #eee 90%);
border-radius: 5px;
}

.rapid-inspector-choice .choice-wrap {
display: flex;
flex: 1;
margin: 10px;
height: 50px;
display: flex;
flex: 1;
margin: 10px;
height: 50px;
}

.rapid-inspector-choice .choice-wrap > button {
Expand Down
4 changes: 2 additions & 2 deletions data/core.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,7 +820,7 @@ en:
title: OpenStreetMap Notes
maproulette:
tooltip: Tasks from maproulette.org
title: MapRoulette Tasks
title: MapRoulette Task
loading_task_details: Loading Task Details...
detail_title: Details
id_title: Challenge Id / Task Id
Expand Down Expand Up @@ -1212,7 +1212,7 @@ en:
fix_title: Fix Guidelines
trap_title: Common Mistakes
keepRight:
title: KeepRight
title: KeepRight Issue
detail_description: Description
comment: Comment
comment_placeholder: Enter a comment to share with other users.
Expand Down
4 changes: 2 additions & 2 deletions data/l10n/core.en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,7 +1042,7 @@
},
"maproulette": {
"tooltip": "Tasks from maproulette.org",
"title": "MapRoulette Tasks",
"title": "MapRoulette Task",
"loading_task_details": "Loading Task Details...",
"detail_title": "Details",
"id_title": "Challenge Id / Task Id",
Expand Down Expand Up @@ -1535,7 +1535,7 @@
"trap_title": "Common Mistakes"
},
"keepRight": {
"title": "KeepRight",
"title": "KeepRight Issue",
"detail_description": "Description",
"comment": "Comment",
"comment_placeholder": "Enter a comment to share with other users.",
Expand Down
Loading