Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double right click adds a node now? #684

Closed
atiannicelli opened this issue Dec 1, 2022 · 2 comments
Closed

Double right click adds a node now? #684

atiannicelli opened this issue Dec 1, 2022 · 2 comments
Assignees

Comments

@atiannicelli
Copy link

Description

On the current release of rapid a double right click does NOT add a node to a feature. With this version it does? Is this expected? If this is a new design choice I can live with it (but I don't like it :))

This gets me screwed up because I often choose a feature with the left click and then want to bring up the menu with the right click, but now that adds a node! I see that now I don't need the first left click to select the feature before bringing up the menu - I like that, but I personally don't think that right clicking on a feature should add a node.

Version

2.00-alpha.3

What browser are you seeing the problem on? What version are you running?

Chrome v107.0

Steps to reproduce

Double right click on a way between two nodes and one will be added.

The browser URL at the time you encountered the bug

https://mapwith.ai/rapid-v2-alpha3#background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries&id=w163740253&map=20.72/40.66765/-74.18124

@Bonkles Bonkles added this to the v2 General Beta (Extended) milestone Dec 1, 2022
@Bonkles Bonkles moved this to 🏗 In Progress in Rapid v2 Beta Board Dec 7, 2022
@Bonkles Bonkles self-assigned this Dec 7, 2022
Bonkles added a commit that referenced this issue Dec 7, 2022
…as preventing quick left-click to select -> right click to bring open the context menu interactions.
@Bonkles
Copy link
Contributor

Bonkles commented Dec 7, 2022

Thanks for the report, @atiannicelli!

This was an oversight and a bug for sure. I have fixed this by forcing the 'add node on double click' functionality to only honor a second left-click.

You should be able to now left-click a way and right click to bring open the context menu really really fast, like so:

left-and-quick-right-click-works.mov

@Bonkles
Copy link
Contributor

Bonkles commented Dec 7, 2022

Fixed in b41a9ff7b.

@Bonkles Bonkles closed this as completed Dec 7, 2022
Repository owner moved this from 🏗 In Progress to 🏁 Done in Rapid v2 Beta Board Dec 7, 2022
@Bonkles Bonkles moved this from 🏁 Done to Pending Release in Rapid v2 Beta Board Dec 7, 2022
@Bonkles Bonkles moved this from Pending Release to Ready for QA ✅ in Rapid v2 Beta Board Dec 7, 2022
@Bonkles Bonkles moved this from Ready for QA ✅ to 🏁 Done in Rapid v2 Beta Board Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

No branches or pull requests

2 participants