Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerous texture warnings at startup filling the console.log #629

Closed
Bonkles opened this issue Oct 27, 2022 · 3 comments
Closed

Numerous texture warnings at startup filling the console.log #629

Bonkles opened this issue Oct 27, 2022 · 3 comments
Assignees
Milestone

Comments

@Bonkles
Copy link
Contributor

Bonkles commented Oct 27, 2022

At startup, since we went to pixi beta 7 we have been seeing issues flooding the console at startup.

Texture added to the cache with an id [airport.svg] that already had an entry

@Bonkles Bonkles self-assigned this Oct 27, 2022
@Bonkles Bonkles added this to the v2 Alpha 3 milestone Oct 27, 2022
@Bonkles Bonkles moved this from Triage to 🏗 In progress in RapiD v2 Release Board Oct 27, 2022
@Bonkles
Copy link
Contributor Author

Bonkles commented Oct 27, 2022

Looks like this is caused by the recent refactoring of the maki spritesheet. Their names used to be of the form airport-11.svg or airport-15.svg, while temaki just used airport.svg.

Now that maki has been updated, we are seeing collisions in the texture caching because the cache just uses the name of the sprite in the spritesheet, with no mangling for uniqueness.

The solution for me to was to modify the texture packer package to append a maki/ folder name to the start of each spritesheet entry.

@Bonkles
Copy link
Contributor Author

Bonkles commented Oct 27, 2022

As an extra bonus, I have parallelized the texture loading into a single promise.all function instead of several (await) calls in serial. Increase dat startup time!

Bonkles added a commit that referenced this issue Oct 27, 2022
…ting texture cache collisions with temaki icons.
@Bonkles
Copy link
Contributor Author

Bonkles commented Nov 8, 2022

Fixed in 4988a39d9.

@Bonkles Bonkles closed this as completed Nov 8, 2022
@Bonkles Bonkles moved this from 🏗 In progress to 🔖 Pending Release in RapiD v2 Release Board Nov 8, 2022
@Bonkles Bonkles moved this to Pending Release in Rapid v2 Beta Board Nov 30, 2022
@Bonkles Bonkles moved this from Pending Release to 🏁 Done in Rapid v2 Beta Board Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

No branches or pull requests

1 participant