Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when selecting photo imagery #548

Closed
Bonkles opened this issue Aug 16, 2022 · 1 comment
Closed

Error when selecting photo imagery #548

Bonkles opened this issue Aug 16, 2022 · 1 comment
Assignees
Milestone

Comments

@Bonkles
Copy link
Contributor

Bonkles commented Aug 16, 2022

When clicking on a mapillary photo, I see the following error:

/Users/clarkben/working/RapiD/node_modules/@pixi/utils/src/browser/hello.ts:45
Uncaught TypeError TypeError: renderer.selectFeatures is not a function
    at _processClick (/Users/clarkben/working/RapiD/modules/behaviors/BehaviorSelect.js:460:16)
    at _pointerup (/Users/clarkben/working/RapiD/modules/behaviors/BehaviorSelect.js:245:12)
    at emit (/Users/clarkben/working/RapiD/node_modules/eventemitter3/index.js:202:33)
    at InteractionManager2.onPointerComplete (/Users/clarkben/working/RapiD/node_modules/@pixi/interaction/src/InteractionManager.ts:1242:18)
    at InteractionManager2.onPointerUp (/Users/clarkben/working/RapiD/node_modules/@pixi/interaction/src/InteractionManager.ts:1302:14)
_processClick @ /Users/clarkben/working/RapiD/modules/behaviors/BehaviorSelect.js:460:16

Also, when we attempt to ease the map to center the selected point, we generate a different error:

Uncaught TypeError TypeError: Cannot read properties of null (reading 'type')
    at zoomPan (/Users/clarkben/working/RapiD/modules/renderer/map.js:299:54)
    at call (/Users/clarkben/working/RapiD/node_modules/d3-dispatch/src/dispatch.js:57:72)
    at emit (/Users/clarkben/working/RapiD/node_modules/d3-zoom/src/zoom.js:219:17)
    at zoom (/Users/clarkben/working/RapiD/node_modules/d3-zoom/src/zoom.js:207:12)
    at <anonymous> (/Users/clarkben/working/RapiD/node_modules/d3-zoom/src/zoom.js:172:15)
    at tick (/Users/clarkben/working/RapiD/node_modules/d3-transition/src/transition/schedule.js:136:16)
    at timerFlush (/Users/clarkben/working/RapiD/node_modules/d3-timer/src/timer.js:61:48)
    at wake (/Users/clarkben/working/RapiD/node_modules/d3-timer/src/timer.js:71:5)
    --- requestAnimationFrame ---
    at sleep (/Users/clarkben/working/RapiD/node_modules/d3-timer/src/timer.js:108:16)
    at nap (/Users/clarkben/working/RapiD/node_modules/d3-timer/src/timer.js:96:3)
    at wake (/Users/clarkben/working/RapiD/node_modules/d3-timer/src/timer.js:74:5)
    --- requestAnimationFrame ---
    at sleep (/Users/clarkben/working/RapiD/node_modules/d3-timer/src/timer.js:108:16)
    at restart (/Users/clarkben/working/RapiD/node_modules/d3-timer/src/timer.js:39:5)
    at timer (/Users/clarkben/working/RapiD/node_modules/d3-timer/src/timer.js:52:5)
    at create (/Users/clarkben/working/RapiD/node_modules/d3-transition/src/transition/schedule.js:59:16)
    at schedule_default (/Users/clarkben/working/RapiD/node_modules/d3-transition/src/transition/schedule.js:19:3)
    at transition_default2 (/Users/clarkben/working/RapiD/node_modules/d3-transition/src/selection/transition.js:36:9)
    at setTransform (/Users/clarkben/working/RapiD/modules/renderer/map.js:510:12)
    at setCenterZoom (/Users/clarkben/working/RapiD/modules/renderer/map.js:540:14)
    at map3.centerEase (/Users/clarkben/working/RapiD/modules/renderer/map.js:670:7)
    at _processClick (/Users/clarkben/working/RapiD/modules/behaviors/BehaviorSelect.js:455:21)
    at _pointerup (/Users/clarkben/working/RapiD/modules/behaviors/BehaviorSelect.js:245:12)
    at emit (/Users/clarkben/working/RapiD/node_modules/eventemitter3/index.js:202:33)
    at InteractionManager2.onPointerComplete (/Users/clarkben/working/RapiD/node_modules/@pixi/interaction/src/InteractionManager.ts:1242:18)
    at InteractionManager2.onPointerUp (/Users/clarkben/working/RapiD/node_modules/@pixi/interaction/src/InteractionManager.ts:1302:14)
@Bonkles Bonkles added this to the v2 Alpha milestone Aug 16, 2022
@Bonkles Bonkles self-assigned this Aug 16, 2022
@Bonkles
Copy link
Contributor Author

Bonkles commented Aug 16, 2022

Fixed in 9e25997 and fdd725e.

@Bonkles Bonkles closed this as completed Aug 16, 2022
Bonkles added a commit that referenced this issue Aug 16, 2022
@Bonkles Bonkles moved this from Triage to 🔖 Pending Release in RapiD v2 Release Board Aug 16, 2022
@Bonkles Bonkles moved this from 🔖 Pending Release to Ready for QA ✅ in RapiD v2 Release Board Aug 16, 2022
@Bonkles Bonkles moved this to Ready for QA ✅ in Rapid v2 Beta Board Nov 30, 2022
@Bonkles Bonkles moved this from Ready for QA ✅ to 🏁 Done in Rapid v2 Beta Board Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

No branches or pull requests

1 participant