Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support selecting a detection in the URL hash #1515

Closed
bhousel opened this issue Aug 15, 2024 · 0 comments
Closed

Support selecting a detection in the URL hash #1515

bhousel opened this issue Aug 15, 2024 · 0 comments
Assignees
@bhousel
Labels
feature-streetview Issue or request related to the streetview viewer feature-usability Issue or feature related to usability - something hard to do
Milestone
v2.4

Comments

@bhousel
Copy link
Contributor

bhousel commented Aug 15, 2024

Goes along with #1514
We allow a photo to be selected via the URL, e.g. &photo=mapillary/<photoID>
But we should do the same for a detection, e.g. &detection=mapillary-signs/<detectionID>
because these are really two separate things that can be independently selected and highlighted.
@bhousel bhousel added feature-usability Issue or feature related to usability - something hard to do feature-streetview Issue or request related to the streetview viewer labels Aug 15, 2024
@bhousel bhousel self-assigned this Aug 15, 2024
bhousel added a commit that referenced this issue Aug 15, 2024
@bhousel
Support selecting a detection in the URL hash
28f7816 
(closes #1515)

This commit also includes a bunch of cleanup and work to prepare for
improving how we show the detections and the photos, re: #1514
@bhousel bhousel added this to the v2.4 milestone Aug 15, 2024
bhousel added a commit that referenced this issue Aug 15, 2024
@bhousel
WIP on selecting detections
f40f5ef 
(re: #1515)

Work in Progress on:
- Style improvement for detected map features
- If a detection is selected, highlight the images that show that detection

This works, but isn't great. Some problems are:
- the detections aren't very precise
- the icons don't look good
- the images picked that show the detection often don't show it well
  (need to improve tag/segmentation styling)
- We're showing a lot of features that maybe we shouldnt (road markings)
  which clutter the map
- Race condition where multiple things are trying to centerEase the map
  Also should adjust the zoom to better show what we are trying to show.
  (a selected detection with several highlighted images roughly pointing at it)
@bhousel bhousel mentioned this issue Aug 28, 2024
Merged
bhousel added a commit that referenced this issue Aug 28, 2024
@bhousel
WIP on selecting detections
bf042d8 
(re: #1515)

Work in Progress on:
- Style improvement for detected map features
- If a detection is selected, highlight the images that show that detection

This works, but isn't great. Some problems are:
- the detections aren't very precise
- the icons don't look good
- the images picked that show the detection often don't show it well
  (need to improve tag/segmentation styling)
- We're showing a lot of features that maybe we shouldnt (road markings)
  which clutter the map
- Race condition where multiple things are trying to centerEase the map
  Also should adjust the zoom to better show what we are trying to show.
  (a selected detection with several highlighted images roughly pointing at it)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhousel bhousel

Labels
feature-streetview Issue or request related to the streetview viewer feature-usability Issue or feature related to usability - something hard to do
Projects
None yet
Milestone
v2.4
Development

No branches or pull requests
1 participant
@bhousel