Mapillary Integration loads all segmentations without color

[sturksever]

Description

Mapillary photo overlay renders all segments with no colors when you have turned on the traffic signs layer. It seems like we are just loading all the raw segmentations and rendering them without any color coding. Please see below image on Rapid

Here is a screenshot from iD, when you click on a map feature or traffic sign we show it on the image in MJS.

Screenshots

No response

Version

2.3.2

What browser are you seeing the problem on? What version are you running?

No response

The OS you're using

No response

Steps to reproduce

• Go to Rapid and enable Mapillary Imagery layer
• Enable traffic sign layer
• View the imagery

The browser URL at the time you encountered the bug

https://rapideditor.org/rapid#map=20.12/30.63361/104.07387&background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries&id=w485149342&photo=mapillary/188334986520037&photo_overlay=mapillary,mapillary-signs

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

No response

[bhousel]

Thanks for reporting @sturksever , I haven't tried this feature out, but I agree it should display the segmentation better.

[bhousel]

Looks like I commented it out a while ago. I'll revisit and find a way to make this code safe to be called async.
(The concern is probably - highlighting the wrong thing if the user switches to another image during the time it takes to load the detections)

Rapid/modules/behaviors/SelectBehavior.js

Lines 401 to 409 in 695d7f2

	service.getDetectionsAsync(dataID)
	.then(detections => {
	if (!detections.length) return;
	const imageID = detections[0].image.id;
	context.systems.photos.selectPhoto('mapillary', imageID);
	//todo: check on the asyncness of this code
	// service.highlightDetection(detections[0]);
	});