Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remember user's preference for whether sidebar is expanded #1479

Closed
bhousel opened this issue Jul 1, 2024 · 0 comments
Closed

Remember user's preference for whether sidebar is expanded #1479

bhousel opened this issue Jul 1, 2024 · 0 comments
Assignees
@bhousel
Labels
feature-usability Issue or feature related to usability - something hard to do
Milestone
v2.4

Comments

@bhousel
Copy link
Contributor

bhousel commented Jul 1, 2024

from maproulette/maproulette3#2371

To save space, I usually collapse the Rapid sidebar to have a larger map view within MapRoulette.

When I am done with a task and go to the next one, this state is not remembered.. I would like to have that option.
cc @Bonkles @bhousel

We can save this in localStorage, similarly to how we save user's preference for expanding different UI sections (like raw tag editor, etc).
@bhousel bhousel added the feature-usability Issue or feature related to usability - something hard to do label Jul 1, 2024
bhousel added a commit that referenced this issue Jul 26, 2024
@bhousel
Fix sidebar interactivity and other changes
75ff758 
summary:
- dragging sidebar resizer works
- toggling in/out by clicking resizer works
- persist sidebar preferences to local storage (closes #1479)
- fix "viewport jumps after toggling sidebar" (closes #1468)
  (though the resizing is still jerky as it fights with map draws and I'd like to improve that.)
- a few places rename systems to use shortnames (e.g. photosystem -> photos)
- we don't need utilFastMouse anymore

todo:
- I left the sidebar resizer red - need to style it nicer
- Remove that "Inspect" button?  It's unnecessary with a proper resizer
- ui.resize doesn't pan the map completely correctly to account for the resize
  I divided pan amount by half, expecting that the map will grow on both sides (from center) now
  But this still isn't totally right - the math needs to be based on main-map dims not sidebar dims.
  (for fun, this effect of weird pan is worse when the map is rotated)
@bhousel bhousel added this to the v2.4 milestone Jul 26, 2024
@bhousel bhousel self-assigned this Jul 26, 2024
@bhousel bhousel mentioned this issue Jul 31, 2024
Merged
@mvexel mvexel mentioned this issue Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhousel bhousel

Labels
feature-usability Issue or feature related to usability - something hard to do
Projects
None yet
Milestone
v2.4
Development

No branches or pull requests
1 participant
@bhousel