Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Open Buildings: aggregate dataset sources on the back-end #1300

Closed
Bonkles opened this issue Jan 18, 2024 · 2 comments
Closed

Google Open Buildings: aggregate dataset sources on the back-end #1300

Bonkles opened this issue Jan 18, 2024 · 2 comments
Assignees
Labels
data-buildings Issue or request related to a building data source
Milestone

Comments

@Bonkles
Copy link
Contributor

Bonkles commented Jan 18, 2024

Description

We need to ensure that Rapid shows all data from this set with a 'source=esri/Google_Open_Buildings' changeset tag.

The actual work on this will be done in the backend of the Map with AI service, transforming all the individual layer source names to the correct one as it fields the requests for data.

@Bonkles Bonkles added the data-buildings Issue or request related to a building data source label Jan 18, 2024
@Bonkles Bonkles added this to the v2.3 milestone Jan 18, 2024
@Bonkles Bonkles self-assigned this Jan 18, 2024
@bhousel bhousel modified the milestones: v2.3, v2.2.5 Jan 19, 2024
@Bonkles
Copy link
Contributor Author

Bonkles commented Jan 26, 2024

Done! Example payload response for the Google Buildings for Argentina dataset:

<?xml version="1.0" encoding="utf-8"?>
<osm version="0.6" generator="fb_conflation_service" copyright="OpenStreetMap and contributors" attribution="http://www.openstreetmap.org/copyright">
  <bounds minlat="-37.991823653139" minlon="-63.605333991293" maxlat="-37.987514371064" maxlon="-63.59986620402"/>
  <node id="-3670328315587290905" visible="true" lat="-37.988778383661" lon="-63.602226765017"/>
  <node id="-915654462477123032" visible="true" lat="-37.988779123511" lon="-63.602314352554"/>
  <node id="-2229728471177930709" visible="true" lat="-37.988656638945" lon="-63.602316003657"/>
  <node id="-3094783616627193699" visible="true" lat="-37.988655899094" lon="-63.602228417019"/>
  <way id="-3389096870112667333" action="modify" visible="true">
    <nd ref="-3670328315587290905"/>
    <nd ref="-915654462477123032"/>
    <nd ref="-2229728471177930709"/>
    <nd ref="-3094783616627193699"/>
    <nd ref="-3670328315587290905"/>
    <tag k="building" v="yes"/>
    <tag k="source" v="esri/Google_Open_Buildings"/>
  </way>
</osm>

@bhousel
Copy link
Contributor

bhousel commented Feb 2, 2024

Just tested this myself and it looks good! 👍

@bhousel bhousel closed this as completed Feb 2, 2024
bhousel added a commit that referenced this issue Nov 27, 2024
(re #1300)

There are actually two places that this happens,
and the old code only had it in one place.

I moved the function into the Esri service.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-buildings Issue or request related to a building data source
Projects
None yet
Development

No branches or pull requests

2 participants