-
Notifications
You must be signed in to change notification settings - Fork 92
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes for issues where Extent is not revealed correctly in walkthrough
(closes #1527, closes #1408) This can happen because - We were caching rectangles for the map size and container size, and these things could be off by a little bit after the user resizes or the sidebar changes size, so we don't cache them anymore, we just call getBoundingClientRect() at the time we need the rectangle This also changes how we treat `revealExtent`: - These were previously just treated as rectangles, which would be wrong when the map rotates. This wasn't too much of an issue, because we didn't ask the user to rotate the map during the steps where we would reveal an Extent. - But now we treat them as polygons and project each corner, so they can handle being rotated and resized much better than before.
- Loading branch information
Showing
4 changed files
with
220 additions
and
198 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.