Updated the WAST version #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f floating-point numbers
fabienrenaud
requested changes
Jul 2, 2024
| @@ -83,7 +83,7 @@ The results here-below were computed on January the 30th, 2024 with the followin | |||
| | tapestry | 5.8.3 | | |||
| | underscore | 1.97 | | |||
| | yasson | 3.0.3 | | |||
| | wast | 0.0.12.1 | | |||
| | wast | 0.0.13.2 | | |||
There was a problem hiding this comment.
Please revert this change in the readme as this list of versions is meant to indicate what lib versions were tested on the charts on this page.
There was a problem hiding this comment.
This library, which has just been added, has not been tested yet, and there is no performance data for this library in the chart. It seems that it can be updated.
| @@ -153,6 +153,6 @@ public Object quickbuf_json() throws Exception { | |||
| @Benchmark | |||
| @Override | |||
| public Object wast() throws Exception { | |||
| return io.github.wycst.wast.json.JSON.parseObject(JSON_SOURCE().nextString(), JSON_SOURCE().pojoType(), ReadOption.UseJDKDoubleParser); | |||
| return io.github.wycst.wast.json.JSON.parseObject(JSON_SOURCE().nextString(), JSON_SOURCE().pojoType()/*, ReadOption.UseJDKDoubleParser*/); | |||
There was a problem hiding this comment.
Either:
- remove entirely the
ReadOption.UseJDKDoubleParsepart to show/suggest it's the normal default setup; - or, add a comment explaining why this is kept here but commented.
| @@ -187,7 +187,7 @@ public Object quickbuf_json() throws Exception { | |||
| @Override | |||
| public Object wast() throws Exception { | |||
| ByteArrayOutputStream baos = JsonUtils.byteArrayOutputStream(); | |||
| io.github.wycst.wast.json.JSON.writeJsonTo(JSON_SOURCE().nextPojo(), baos, WriteOption.WriteDecimalUseToString); | |||
| io.github.wycst.wast.json.JSON.writeJsonTo(JSON_SOURCE().nextPojo(), baos/*, WriteOption.WriteDecimalUseToString*/); | |||
fabienrenaud
approved these changes
Jul 2, 2024
| @@ -83,7 +83,7 @@ The results here-below were computed on January the 30th, 2024 with the followin | |||
| | tapestry | 5.8.3 | | |||
| | underscore | 1.97 | | |||
| | yasson | 3.0.3 | | |||
| | wast | 0.0.12.1 | | |||
| | wast | 0.0.13.2 | | |||
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the WAST version to optimize the read and write performance of double