Skip to content

Heretic: add true color support #530

Heretic: add true color support

Heretic: add true color support #530

Triggered via pull request November 28, 2023 10:05
Status Success
Total duration 2m 30s
Artifacts

cpp-linter.yml

on: pull_request
Matrix: cpp-linter
Fit to window
Zoom out
Zoom in

Annotations

10 warnings and 10 notices
/src/heretic/am_map.c:37:9 [modernize-macro-to-enum]: src/heretic/am_map.c#L37
macro 'NUMSHADES' defines an integral constant; prefer an enum instead
/src/heretic/am_map.c:38:16 [cppcoreguidelines-avoid-non-const-global-variables]: src/heretic/am_map.c#L38
variable 'color_shades' is non-const and globally accessible, consider making it const
/src/heretic/am_map.c:589:29 [bugprone-macro-parentheses]: src/heretic/am_map.c#L589
macro argument should be enclosed in parentheses
/src/heretic/am_map.c:604:16 [cppcoreguidelines-avoid-non-const-global-variables]: src/heretic/am_map.c#L604
variable 'stopped' is non-const and globally accessible, consider making it const
/src/heretic/am_map.c:1121:9 [clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]: src/heretic/am_map.c#L1121
Call to function 'memcpy' is insecure as it does not provide security checks introduced in the C11 standard. Replace with analogous functions that support length arguments or provides boundary checks such as 'memcpy_s' in case of C11
/src/heretic/am_map.c:1121:16 [bugprone-implicit-widening-of-multiplication-result]: src/heretic/am_map.c#L1121
result of multiplication in type 'int' is used as a pointer offset after an implicit widening conversion to type 'ptrdiff_t'
/src/heretic/am_map.c:1414:5 [readability-isolate-declaration]: src/heretic/am_map.c#L1414
multiple declarations in a single statement reduces readability
/src/heretic/am_map.c:1414:20 [cppcoreguidelines-init-variables]: src/heretic/am_map.c#L1414
variable 'ErrorAccTemp' is not initialized
Run clang-format on src/heretic/am_map.c: src/heretic/am_map.c#L1
File src/heretic/am_map.c does not conform to Custom style guidelines. (lines 591, 593, 598, 1153, 1291, 1306, 1308, 1309, 1310)
Run clang-format on src/heretic/d_main.c: src/heretic/d_main.c#L1
File src/heretic/d_main.c does not conform to Custom style guidelines. (lines 878)
Run clang-format on src/heretic/r_data.c: src/heretic/r_data.c#L1
File src/heretic/r_data.c does not conform to Custom style guidelines. (lines 532, 533, 534, 535, 536, 538, 539, 540, 541, 542, 544, 546, 547, 548, 549, 551, 552, 553, 554, 555, 557, 558, 559, 560, 561, 563, 564, 565, 566, 567, 568, 569, 570, 571, 572, 573, 574, 575, 577, 578, 579, 580, 582, 583, 584, 585, 586, 587, 589, 590, 634, 635, 636)
Run clang-format on src/heretic/r_draw.c: src/heretic/r_draw.c#L1
File src/heretic/r_draw.c does not conform to Custom style guidelines. (lines 235, 314)
Run clang-format on src/heretic/r_local.h: src/heretic/r_local.h#L1
File src/heretic/r_local.h does not conform to Custom style guidelines. (lines 193)
Run clang-format on src/heretic/r_main.c: src/heretic/r_main.c#L1
File src/heretic/r_main.c does not conform to Custom style guidelines. (lines 882, 883)
Run clang-format on src/heretic/r_plane.c: src/heretic/r_plane.c#L1
File src/heretic/r_plane.c does not conform to Custom style guidelines. (lines 534)
Run clang-format on src/heretic/r_things.c: src/heretic/r_things.c#L1
File src/heretic/r_things.c does not conform to Custom style guidelines. (lines 674)
Run clang-format on src/i_video.c: src/i_video.c#L1
File src/i_video.c does not conform to Custom style guidelines. (lines 2056, 2057, 2058, 2059, 2060)
Run clang-format on src/i_video.h: src/i_video.h#L1
File src/i_video.h does not conform to Custom style guidelines. (lines 69)