-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optim(ci): use npm ci
for install and cache npm
#323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `npm ci` is installation for, well, CI, and is a good bit faster - c.f. https://docs.npmjs.com/cli/v8/commands/npm-ci - cache `npm` installation with `setup-node` for speedier installs - upgrade `setup-node` as this was released in v2.2.0: https://github.com/actions/setup-node/releases/tag/v2.2.0
agilgur5
added
kind: internal
Changes only affect the internals, and _not_ the public API or external-facing docs
kind: optimization
Performance, space, size, etc improvement
labels
May 10, 2022
Hard to tell from just a single CI run, but looks ~25% faster (basically installation is twice as fast). And there's no cache on this run just yet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind: internal
Changes only affect the internals, and _not_ the public API or external-facing docs
kind: optimization
Performance, space, size, etc improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Optimize CI by using
npm ci
and cachingnpm
installsDetails
npm ci
is installation for, well, CI, and is a good bit fastercache
npm
installation withsetup-node
for speedier installssetup-node
as this was released in v2.2.0