-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flake improvments #93
Conversation
(because that is the purpose of that command as far as I understand it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking, just comments.
self | ||
, flake-utils | ||
, naersk | ||
, nixpkgs | ||
, treefmt-nix | ||
, rust-overlay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually prefer this, it's the same style that https://github.com/nixos/nixpkgs uses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to already have been a lot of discussion on the topic: kamadorueda/alejandra#95
I don't care that much at the end of the day. I use alejandra because I found it's formatting pretty helpful but unintrusive working with it. (Style discussions are some of the most annoying things devs - let's be honest - fight about imo)
Judging by context I assume you don't insist on using something else?!
@@ -1,8 +1,7 @@ | |||
{ | |||
projectRootFile = "Cargo.toml"; | |||
programs = { | |||
# alejandra.enable = true; | |||
alejandra.enable = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know this package, but I'm gonna check it out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Regarding #75: I went looking for the tests because they did not show up here but I think that might be because they aren't yet in the tree of this branch (?! idk) edit: ah no. i think it's because the paths aren't in there. makes sense |
Sounds plausible, but annoying. Maybe I'll try merging main into a PR and see if it triggers CI. |
Tracking issue: #72
nix flake check
cargo test
when building via flake to ensure working output