Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(exa PR) 370: Replace fixed colors by named ones so that it works well with any color scheme #64

Merged
merged 3 commits into from
Jul 30, 2023

Conversation

cafkafk
Copy link
Member

@cafkafk cafkafk commented Jul 29, 2023

github.com/ogham/exa/pull/370

@cafkafk cafkafk changed the title (exa PR) 370 (exa PR) 370: Replace fixed colors by named ones so that it works well with any color scheme Jul 29, 2023
@sbatial
Copy link
Collaborator

sbatial commented Jul 29, 2023

Note:

- github.com/ogham/exa/pulls/370
+ github.com/ogham/exa/pull/370

is probably what you meant.

ogham/exa/pull/370 (test: ogham/exa/pull/370) should also suffice to let github auto-link it

@sbatial
Copy link
Collaborator

sbatial commented Jul 29, 2023

looks fine to me. the code at least. I'm currently not able to compare the colors but will do so (probably later tonight. idk yet)

Signed-off-by: Christina Sørensen <[email protected]>
@cafkafk
Copy link
Member Author

cafkafk commented Jul 30, 2023

@sbatial you were correct, merging main triggered the workflow!

Copy link
Collaborator

@sbatial sbatial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks better to me.

I feel like the color-scale of the sizes could maybe be improved. But it really wasn't any better before.

On exa mega and kilo numerals look very similar/the same to me.
After this change byte/kilobyte looks pretty similar

@sbatial sbatial mentioned this pull request Jul 30, 2023
63 tasks
@cafkafk cafkafk merged commit c68b357 into main Jul 30, 2023
@sbatial sbatial deleted the pr-370 branch July 30, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants