Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(exa PR) 1057: add icon for Vagrantfile #45

Merged
merged 1 commit into from
Jul 30, 2023
Merged

(exa PR) 1057: add icon for Vagrantfile #45

merged 1 commit into from
Jul 30, 2023

Conversation

cafkafk
Copy link
Member

@cafkafk cafkafk commented Jul 29, 2023

github.com/ogham/exa/pulls/1057

@cafkafk cafkafk changed the title (exa PR) 1057 (exa PR) 1057: add icon for Vagrantfile Jul 29, 2023
sbatial
sbatial approved these changes Jul 30, 2023
View reviewed changes
Copy link
Collaborator

@sbatial sbatial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot find anything about this being the vagrant icon on nerdfonts but it works for me

@cafkafk
Copy link
Member Author

cafkafk commented Jul 30, 2023 •
edited
Loading

I cannot find anything about this being the vagrant icon on nerdfonts but it works for me

Actually, it seems like it's the same icon that https://starship.rs/ uses for vagrant, so I feel like it's reasonable.

@cafkafk cafkafk merged commit cb25a12 into main Jul 30, 2023
@sbatial sbatial deleted the pr-1057 branch July 30, 2023 11:51
@sbatial sbatial mentioned this pull request Jul 30, 2023
Closed
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbatial sbatial sbatial approved these changes

Assignees
No one assigned
Labels
features › icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cafkafk @sbatial @Theta-Dev