(exa PR) 1070: Make symlinks report their target's size, if valid #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cafkafk
changed the title
cafkafk
added
help wanted
sbatial
approved these changes
Jul 30, 2023
There was a problem hiding this comment.
I've tried it on a few samples and I find it actually really nice!
One thing: Symlinks have currently set their names bytecount as their size (if i didn't miss anything).
I don't know why anyone would need that/rely on it but we should keep in mind that that might break someone nuclear powerplant.
reference: https://xkcd.com/1172/
Co-authored-by: Luc Ritchie <[email protected]> Signed-off-by: Christina Sørensen <[email protected]>
|
LGTM 👍
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ogham/exa#1070