Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-git option #168

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Add --no-git option #168

merged 6 commits into from
Aug 28, 2023

Conversation

Aehmlo
Copy link
Contributor

@Aehmlo Aehmlo commented Aug 26, 2023

This PR adds the --no-git option. This option overrides --git in all cases and disables showing the Git status of files in long view (-l). This enables users of shell aliases and the like to turn off git status display in an ad hoc manner.

It might someday be worth looking into automatic --no--prefixed versions of flags, but for now, this works.

(This is my first contribution to this codebase; I've done my best to make all the appropriate changes, but I'd appreciate any pointers if there's something I've missed. I took inspiration from the --no-icons option as prior art.)

@Aehmlo Aehmlo requested a review from cafkafk as a code owner August 26, 2023 23:48
Copy link
Member

@PThorpe92 PThorpe92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can just try to match the current wording/terminology in each section to other similar options.
Otherwise, LGTM 👍

README.md Show resolved Hide resolved
@cafkafk
Copy link
Member

cafkafk commented Aug 27, 2023

At first glance this looks good, but I'd like to have this affect the other git related flags, namely --git-repos and --git-repos-no-status.

Aehmlo and others added 2 commits August 27, 2023 19:06
This option overrides --git in all cases and disables showing the Git status of
files in long view (--long/-l).
Signed-off-by: Christina Sørensen <[email protected]>
@cafkafk
Copy link
Member

cafkafk commented Aug 27, 2023

At first glance this looks good, but I'd like to have this affect the other git related flags, namely --git-repos and --git-repos-no-status.

I added this, and made the commit summaries conform to conventional commit. This is probably good to go but I wanna test this a little more and give a little time for feedback in case I did something stupid.

Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local testing seems to indicate this working, waiting for CI to pass then merging this, ty for the PR 👍

@cafkafk cafkafk merged commit 511b229 into eza-community:main Aug 28, 2023
@Aehmlo Aehmlo deleted the no-git branch August 29, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants