-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added git-ignored color/style option #133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Please add the appropriate entry in the man-page as well. :)
👍 Now I'll take a look at some less trivial issues 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for merge after green checks. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit summaries should conform to conventional commits, I'll fix that ASAP
I rebased, reworded, and tried to force push, but I think I don't have the perms to do so. Here's what I changed the commit summaries into: d94621e feat: add git-ignored color/style option
efb01da doc: add git-ignored color/style to manpage You can make them something else ofc! |
Rebased with commit messages edited: will keep in mind for future commits. 👍 |
Awesome, I'll merge when tests pass, thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I tried to specify colors of ignored git files, and then saw that it was an issue on the exa page. Turns out it was an incredibly trivial fix 😄
So I see some recent activity on the exa page, but either way I am glad to see community stepping up to maintain this project, and I will definitely do my part as a long time exa user to contribute to which ever project.