Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance Work #103

Merged
merged 9 commits into from
Jan 31, 2024
Merged

Maintenance Work #103

merged 9 commits into from
Jan 31, 2024

Conversation

razvanphp
Copy link
Collaborator

@razvanphp razvanphp commented Jan 10, 2024

  • Add github actions, fix phpunit tests
  • Repacked the test p12 cert so it works with openssl3 in PHP 8.2, see https://www.php.net/manual/en/function.openssl-pkcs12-read.php#128992
  • Remove unused circleci, scrutinizer and travis configs
  • Add PHP_CodeSniffer (phpcs) config for PSR12 standard, fix all errors and add it as github actions step
  • Add test coverage badge somewhere from scrutinizer
  • Add PHPStan analyse

@razvanphp razvanphp requested a review from eymengunay January 30, 2024 08:21
Copy link
Owner

@eymengunay eymengunay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @razvanphp,

Thank you so much for your valuable contribution! 👏 Your extensive work on this pull request is truly appreciated. I've reviewed the changes, and everything looks fantastic to me. Your effort is a significant boost to the project.

Thanks again for your time and dedication!

@razvanphp razvanphp merged commit a94b97e into master Jan 31, 2024
7 checks passed
@razvanphp razvanphp deleted the maintenance-work branch January 31, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants