Skip to content

Commit

Permalink
Merge remote-tracking branch 'kennethjiang/master'
Browse files Browse the repository at this point in the history
Box3FromObject debugging code removed, too.
  • Loading branch information
eyal0 committed May 7, 2017
2 parents 957072e + 953e1d8 commit d5bc073
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 25 deletions.
13 changes: 1 addition & 12 deletions octoprint_slicer/static/js/octoprint_slicer.min.js
Original file line number Diff line number Diff line change
Expand Up @@ -34666,7 +34666,7 @@ function isDev() {

if (!isDev() && typeof Raven !== 'undefined') {
Raven.config('https://[email protected]/141297', {
release: '1.2.6',
release: '1.2.7',
ignoreErrors: ["Failed to execute 'arc' on 'CanvasRenderingContext2D': The radius provided", "Cannot read property 'highlightFill' of undefined", "Argument 1 of SVGMatrix.translate is not a finite floating-point value", /_jp.*is not a function/, "chrome is not defined", "You cannot apply bindings multiple times to the same element.", "SVG_MATRIX_NOT_INVERTABLE", "The index is not in the allowed range."]
}).install();
}
Expand Down Expand Up @@ -35166,17 +35166,6 @@ function SlicerViewModel(parameters) {
groupBox3.expandByPoint(model.userData.box3FromObject().min);
groupBox3.expandByPoint(model.userData.box3FromObject().max);
});
var DEBUGGING = false;
if (DEBUGGING) {
var oldBox3 = new Box3().setFromObject(group);
var maxDiff = groupBox3.max.clone().sub(oldBox3.max);
var minDiff = groupBox3.min.clone().sub(oldBox3.min);
var EPSILON = 0.0001; // Set this to 0 to see even microscopic differences.
if (maxDiff.x > EPSILON || maxDiff.y > EPSILON || maxDiff.z > EPSILON || minDiff.x > EPSILON || minDiff.y > EPSILON || minDiff.z > EPSILON) {
console.log("new - old: " + JSON.stringify(groupBox3.max.clone().sub(oldBox3.max)) + "," + JSON.stringify(groupBox3.min.clone().sub(oldBox3.min)));
console.log("new, old: " + JSON.stringify(groupBox3) + "," + JSON.stringify(oldBox3));
}
}

sliceRequestData = self.sliceRequestData(self.slicingViewModel, groupBox3.getCenter());

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
plugin_name = "OctoPrint-Slicer"

# The plugin's version. Can be overwritten within OctoPrint's internal data via __plugin_version__ in the plugin module
plugin_version = "1.2.6.20170503"
plugin_version = "1.2.7"

# The plugin's description. Can be overwritten within OctoPrint's internal data via __plugin_description__ in the plugin
# module
Expand Down
13 changes: 1 addition & 12 deletions src/slicer.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function isDev() {

if ( ! isDev() && typeof(Raven) !== 'undefined' ) {
Raven.config('https://[email protected]/141297', {
release: '1.2.6',
release: '1.2.7',
ignoreErrors: [
"Failed to execute 'arc' on 'CanvasRenderingContext2D': The radius provided",
"Cannot read property 'highlightFill' of undefined",
Expand Down Expand Up @@ -527,17 +527,6 @@ function SlicerViewModel(parameters) {
groupBox3.expandByPoint(model.userData.box3FromObject().min);
groupBox3.expandByPoint(model.userData.box3FromObject().max);
});
let DEBUGGING = false;
if (DEBUGGING) {
var oldBox3 = new THREE.Box3().setFromObject(group);
var maxDiff = groupBox3.max.clone().sub(oldBox3.max);
var minDiff = groupBox3.min.clone().sub(oldBox3.min);
var EPSILON = 0.0001; // Set this to 0 to see even microscopic differences.
if (maxDiff.x > EPSILON || maxDiff.y > EPSILON || maxDiff.z > EPSILON || minDiff.x > EPSILON || minDiff.y > EPSILON || minDiff.z > EPSILON) {
console.log("new - old: " + JSON.stringify(groupBox3.max.clone().sub(oldBox3.max)) + "," + JSON.stringify(groupBox3.min.clone().sub(oldBox3.min)));
console.log("new, old: " + JSON.stringify(groupBox3) + "," + JSON.stringify(oldBox3));
}
}

sliceRequestData = self.sliceRequestData(self.slicingViewModel, groupBox3.getCenter());

Expand Down

0 comments on commit d5bc073

Please sign in to comment.