Provide static require analysis in urlencoded parser

closes #120 closes #121
expressjs · Sep 4, 2015 · 9d8c719 · 9d8c719
1 parent 79d0972
commit 9d8c719
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,3 +1,8 @@
+unreleased
+==========
+
+  * Provide static `require` analysis in `urlencoded` parser
+
 1.13.3 / 2015-07-31
 ===================
 

diff --git a/lib/types/urlencoded.js b/lib/types/urlencoded.js
@@ -207,12 +207,22 @@ function parameterCount(body, limit) {
 function parser(name) {
   var mod = parsers[name]
 
-  if (mod) {
+  if (mod !== undefined) {
     return mod.parse
   }
 
-  // load module
-  mod = parsers[name] = require(name)
+  // this uses a switch for static require analysis
+  switch (name) {
+    case 'qs':
+      mod = require('qs')
+      break
+    case 'querystring':
+      mod = require('querystring')
+      break
+  }
+
+  // store to prevent invoking require()
+  parsers[name] = mod
 
   return mod.parse
 }