lint: apply standard 12 style

expressjs · Dec 16, 2018 · 2b73852 · 2b73852
1 parent fdba887
commit 2b73852
Show file tree

Hide file tree

Showing 8 changed files with 54 additions and 54 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -22,7 +22,7 @@ before_install:
   - "npm config set shrinkwrap false"
   # Setup Node.js version-specific dependencies
   - "test $TRAVIS_NODE_VERSION != '0.8' || npm rm --save-dev istanbul"
-  - "test $(echo $TRAVIS_NODE_VERSION | cut -d. -f1) -ge 4 || npm rm --save-dev $(grep -E '\"eslint\\S*\"' package.json | cut -d'\"' -f2)"
+  - "test $(echo $TRAVIS_NODE_VERSION | cut -d. -f1) -ge 6 || npm rm --save-dev $(grep -E '\"eslint\\S*\"' package.json | cut -d'\"' -f2)"
   # Update Node.js modules
   - "test ! -d node_modules || npm prune"
   - "test ! -d node_modules || npm rebuild"

diff --git a/lib/types/urlencoded.js b/lib/types/urlencoded.js
@@ -266,7 +266,7 @@ function simpleparser (options) {
     }
 
     debug('parse urlencoding')
-    return parse(body, undefined, undefined, {maxKeys: parameterLimit})
+    return parse(body, undefined, undefined, { maxKeys: parameterLimit })
   }
 }
 

diff --git a/package.json b/package.json
@@ -21,13 +21,13 @@
     "type-is": "~1.6.16"
   },
   "devDependencies": {
-    "eslint": "4.19.1",
-    "eslint-config-standard": "11.0.0",
-    "eslint-plugin-import": "2.13.0",
+    "eslint": "5.10.0",
+    "eslint-config-standard": "12.0.0",
+    "eslint-plugin-import": "2.14.0",
     "eslint-plugin-markdown": "1.0.0-beta.6",
-    "eslint-plugin-node": "6.0.1",
-    "eslint-plugin-promise": "3.8.0",
-    "eslint-plugin-standard": "3.1.0",
+    "eslint-plugin-node": "7.0.1",
+    "eslint-plugin-promise": "4.0.1",
+    "eslint-plugin-standard": "4.0.0",
     "istanbul": "0.4.5",
     "methods": "1.1.2",
     "mocha": "2.5.3",

diff --git a/test/body-parser.js b/test/body-parser.js
@@ -110,9 +110,9 @@ describe('bodyParser()', function () {
 
   describe('with verify option', function () {
     it('should apply to json', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] === 0x20) throw new Error('no leading space')
-      }})
+      } })
 
       request(server)
         .post('/')
@@ -122,9 +122,9 @@ describe('bodyParser()', function () {
     })
 
     it('should apply to urlencoded', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] === 0x20) throw new Error('no leading space')
-      }})
+      } })
 
       request(server)
         .post('/')

diff --git a/test/json.js b/test/json.js
@@ -390,9 +390,9 @@ describe('bodyParser.json()', function () {
     })
 
     it('should error from verify', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] === 0x5b) throw new Error('no arrays')
-      }})
+      } })
 
       request(server)
         .post('/')
@@ -402,9 +402,9 @@ describe('bodyParser.json()', function () {
     })
 
     it('should error with type = "entity.verify.failed"', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] === 0x5b) throw new Error('no arrays')
-      }})
+      } })
 
       request(server)
         .post('/')
@@ -415,12 +415,12 @@ describe('bodyParser.json()', function () {
     })
 
     it('should allow custom codes', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] !== 0x5b) return
         var err = new Error('no arrays')
         err.status = 400
         throw err
-      }})
+      } })
 
       request(server)
         .post('/')
@@ -430,12 +430,12 @@ describe('bodyParser.json()', function () {
     })
 
     it('should allow custom type', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] !== 0x5b) return
         var err = new Error('no arrays')
         err.type = 'foo.bar'
         throw err
-      }})
+      } })
 
       request(server)
         .post('/')
@@ -446,9 +446,9 @@ describe('bodyParser.json()', function () {
     })
 
     it('should include original body on error object', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] === 0x5b) throw new Error('no arrays')
-      }})
+      } })
 
       request(server)
         .post('/')
@@ -459,9 +459,9 @@ describe('bodyParser.json()', function () {
     })
 
     it('should allow pass-through', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] === 0x5b) throw new Error('no arrays')
-      }})
+      } })
 
       request(server)
         .post('/')
@@ -471,9 +471,9 @@ describe('bodyParser.json()', function () {
     })
 
     it('should work with different charsets', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] === 0x5b) throw new Error('no arrays')
-      }})
+      } })
 
       var test = request(server).post('/')
       test.set('Content-Type', 'application/json; charset=utf-16')
@@ -482,9 +482,9 @@ describe('bodyParser.json()', function () {
     })
 
     it('should 415 on unknown charset prior to verify', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         throw new Error('unexpected verify call')
-      }})
+      } })
 
       var test = request(server).post('/')
       test.set('Content-Type', 'application/json; charset=x-bogus')

diff --git a/test/raw.js b/test/raw.js
@@ -248,9 +248,9 @@ describe('bodyParser.raw()', function () {
     })
 
     it('should error from verify', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] === 0x00) throw new Error('no leading null')
-      }})
+      } })
 
       var test = request(server).post('/')
       test.set('Content-Type', 'application/octet-stream')
@@ -259,12 +259,12 @@ describe('bodyParser.raw()', function () {
     })
 
     it('should allow custom codes', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] !== 0x00) return
         var err = new Error('no leading null')
         err.status = 400
         throw err
-      }})
+      } })
 
       var test = request(server).post('/')
       test.set('Content-Type', 'application/octet-stream')
@@ -273,9 +273,9 @@ describe('bodyParser.raw()', function () {
     })
 
     it('should allow pass-through', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] === 0x00) throw new Error('no leading null')
-      }})
+      } })
 
       var test = request(server).post('/')
       test.set('Content-Type', 'application/octet-stream')

diff --git a/test/text.js b/test/text.js
@@ -271,9 +271,9 @@ describe('bodyParser.text()', function () {
     })
 
     it('should error from verify', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] === 0x20) throw new Error('no leading space')
-      }})
+      } })
 
       request(server)
         .post('/')
@@ -283,12 +283,12 @@ describe('bodyParser.text()', function () {
     })
 
     it('should allow custom codes', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] !== 0x20) return
         var err = new Error('no leading space')
         err.status = 400
         throw err
-      }})
+      } })
 
       request(server)
         .post('/')
@@ -298,9 +298,9 @@ describe('bodyParser.text()', function () {
     })
 
     it('should allow pass-through', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] === 0x20) throw new Error('no leading space')
-      }})
+      } })
 
       request(server)
         .post('/')
@@ -310,9 +310,9 @@ describe('bodyParser.text()', function () {
     })
 
     it('should 415 on unknown charset prior to verify', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         throw new Error('unexpected verify call')
-      }})
+      } })
 
       var test = request(server).post('/')
       test.set('Content-Type', 'text/plain; charset=x-bogus')

diff --git a/test/urlencoded.js b/test/urlencoded.js
@@ -519,9 +519,9 @@ describe('bodyParser.urlencoded()', function () {
     })
 
     it('should error from verify', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] === 0x20) throw new Error('no leading space')
-      }})
+      } })
 
       request(server)
         .post('/')
@@ -531,9 +531,9 @@ describe('bodyParser.urlencoded()', function () {
     })
 
     it('should error with type = "entity.verify.failed"', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] === 0x20) throw new Error('no leading space')
-      }})
+      } })
 
       request(server)
         .post('/')
@@ -544,12 +544,12 @@ describe('bodyParser.urlencoded()', function () {
     })
 
     it('should allow custom codes', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] !== 0x20) return
         var err = new Error('no leading space')
         err.status = 400
         throw err
-      }})
+      } })
 
       request(server)
         .post('/')
@@ -559,12 +559,12 @@ describe('bodyParser.urlencoded()', function () {
     })
 
     it('should allow custom type', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] !== 0x20) return
         var err = new Error('no leading space')
         err.type = 'foo.bar'
         throw err
-      }})
+      } })
 
       request(server)
         .post('/')
@@ -575,9 +575,9 @@ describe('bodyParser.urlencoded()', function () {
     })
 
     it('should allow pass-through', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         if (buf[0] === 0x5b) throw new Error('no arrays')
-      }})
+      } })
 
       request(server)
         .post('/')
@@ -587,9 +587,9 @@ describe('bodyParser.urlencoded()', function () {
     })
 
     it('should 415 on unknown charset prior to verify', function (done) {
-      var server = createServer({verify: function (req, res, buf) {
+      var server = createServer({ verify: function (req, res, buf) {
         throw new Error('unexpected verify call')
-      }})
+      } })
 
       var test = request(server).post('/')
       test.set('Content-Type', 'application/x-www-form-urlencoded; charset=x-bogus')
-Original file line number
+Diff line change
@@ Expand Up / @@ -266,7 +266,7 @@ function simpleparser (options) { @@
         }
         debug('parse urlencoding')
-        return parse(body, undefined, undefined, {maxKeys: parameterLimit})
+        return parse(body, undefined, undefined, { maxKeys: parameterLimit })
       }
     }
@@ Expand Down @@