Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nominal support for zabbix v 4.0 #90

Merged
merged 2 commits into from
Dec 16, 2018
Merged

Add nominal support for zabbix v 4.0 #90

merged 2 commits into from
Dec 16, 2018

Conversation

svdasein
Copy link
Collaborator

This just slaps 4.0 in the list of supported versions. I've not tested it beyond my immediate needs but it works well enough for me.

@gdubicki
Copy link
Contributor

See also #85 (comment).

@gdubicki
Copy link
Contributor

gdubicki commented Nov 7, 2018

In 4.0 a few deprecated in 3.4 API methods have been removed:

ZBXNEXT-4247 | removed deprecated API methods: user.updareProfile, user.addMedia, user.updateMedia, user.deleteMedia, usergroup.massAdd, usergroup.massUpdate and usermedia.get

Sources:

@gdubicki
Copy link
Contributor

gdubicki commented Nov 7, 2018

I suggest to remove those 4 methods in this PR (can you, @svdasein ?) and release this library as 4.0.0 (it seems that its version is synchronized with Zabbix) stating in the changelog that some unsupported in 4.0.0 methods have been dropped.

What do you think about this approach, @lehn-etracker ?

@gdubicki
Copy link
Contributor

gdubicki commented Nov 26, 2018

@aladmit : maybe you can reply to my proposal above?

@aladmit
Copy link

aladmit commented Nov 27, 2018

@gdubicki Sounds great for me, but I don`t maintain this project anymore.

If you want to realize this approach and support it, I`ll give all permissions for that.

@gdubicki
Copy link
Contributor

Ok, I will try, @aladmit .

@baurmatt
Copy link
Contributor

@svdasein Could you please include the suggested change of @gdubicki? Would love to see this merged/released! :)

@svdasein
Copy link
Collaborator Author

I'm not the project maintainer - I can't merge anything. Also re: excluding methods - I'm not sure the right approach is to just delete them - there's probably some version checking logic that needs to go in. Again though I'm not the maintainer. I just did that one stupid little hack.

@gdubicki
Copy link
Contributor

@aladmit : so can you please give me maintainer permissions?

@aladmit
Copy link

aladmit commented Dec 16, 2018

@gdubicki Done!

@gdubicki
Copy link
Contributor

Let's add the overdue support for 4.0 for now. I will work on cleaning up non-working methods in a minor update within a few days.

@gdubicki gdubicki merged commit 3e4e73e into express42:master Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants