-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nominal support for zabbix v 4.0 #90
Conversation
See also #85 (comment). |
In 4.0 a few deprecated in 3.4 API methods have been removed:
Sources: |
I suggest to remove those 4 methods in this PR (can you, @svdasein ?) and release this library as 4.0.0 (it seems that its version is synchronized with Zabbix) stating in the changelog that some unsupported in 4.0.0 methods have been dropped. What do you think about this approach, @lehn-etracker ? |
@aladmit : maybe you can reply to my proposal above? |
@gdubicki Sounds great for me, but I don`t maintain this project anymore. If you want to realize this approach and support it, I`ll give all permissions for that. |
Ok, I will try, @aladmit . |
I'm not the project maintainer - I can't merge anything. Also re: excluding methods - I'm not sure the right approach is to just delete them - there's probably some version checking logic that needs to go in. Again though I'm not the maintainer. I just did that one stupid little hack. |
@aladmit : so can you please give me maintainer permissions? |
@gdubicki Done! |
Let's add the overdue support for 4.0 for now. I will work on cleaning up non-working methods in a minor update within a few days. |
This just slaps 4.0 in the list of supported versions. I've not tested it beyond my immediate needs but it works well enough for me.