lock expo-constants version #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
approved these changes
Jan 31, 2024
EvanBacon
added a commit
to expo/expo
that referenced
this pull request
Feb 1, 2024
# Why - reduce chance of issues like this expo/router#918 - Using globals directly is the future. A lot less bundling and resolving. # Test Plan Manually ran this in a dev client, web, and expo go for ios. --------- Co-authored-by: Expo Bot <[email protected]>
EvanBacon
added a commit
to expo/expo
that referenced
this pull request
Feb 1, 2024
- reduce chance of issues like this expo/router#918 - Using globals directly is the future. A lot less bundling and resolving. Manually ran this in a dev client, web, and expo go for ios. --------- Co-authored-by: Expo Bot <[email protected]>
DavidAmyot
pushed a commit
to Villeco-inc/expo-router
that referenced
this pull request
Oct 16, 2024
# Why - reduce chance of issues like this expo/router#918 - Using globals directly is the future. A lot less bundling and resolving. # Test Plan Manually ran this in a dev client, web, and expo go for ios. --------- Co-authored-by: Expo Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Related:
Execution
Test Plan