-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reframe collatz-conjecture exercise instructions as a story #2508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you.
Co-authored-by: Isaac Good <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not totally consistent, but I feel like the introduction contains much of the instructions. Maybe make the rules explicit in the instructions too? And maybe remove some of it from the introduction?
The intention was to reframe the instructions as a story. Since there isn't a real story here, I'm unsure how to incorporate your suggestion. If there are inconsistencies, I'd prefer to fix them instead. Edit: Is the inconsistency that the intro contains the instructions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the inconsistency that the intro contains the instructions?
It is. I'm happy to approve this and maybe tweak this later
The idea of putting the instructions in the intro came directly from other exercises. For example https://github.com/exercism/problem-specifications/blob/main/exercises/eliuds-eggs/introduction.md does the same. Pretty much everything we need to know is in the intro and the instructions contain only a single sentence. |
That's why I said we're inconsistent :) |
So, are we still going ahead with this PR then? |
Sure |
Forum thread
https://forum.exercism.org/t/a-story-for-the-collatz-conjecture-exercise/13961
I also edited the source and source_url to point directly to the Collatz conjecture page on Wikipedia. The old url was just a redirection.