Skip to content

Commit

Permalink
fix: move upgrader to a specific folder
Browse files Browse the repository at this point in the history
  • Loading branch information
@mrexox
mrexox committed Jul 22, 2024
1 parent cd2a660 commit 3985e5f
Show file tree
Hide file tree
Showing 5 changed files with 299 additions and 252 deletions.
19 changes: 19 additions & 0 deletions cmd/commands.go
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
//go:build !no_upgrade

package cmd

import (
"github.com/spf13/cobra"

"github.com/evilmartians/lefthook/internal/lefthook"
)

var commands = [...]func(*lefthook.Options) *cobra.Command{
newVersionCmd,
newAddCmd,
newInstallCmd,
newUninstallCmd,
newRunCmd,
newDumpCmd,
newUpgradeCmd,
}
17 changes: 17 additions & 0 deletions cmd/commands_no_upgrade.go
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
//go:build no_upgrade

package cmd

import (
"github.com/evilmartians/lefthook/internal/lefthook"
"github.com/spf13/cobra"
)

var commands = [...]func(*lefthook.Options) *cobra.Command{
newVersionCmd,
newAddCmd,
newInstallCmd,
newUninstallCmd,
newRunCmd,
newDumpCmd,
}
10 changes: 0 additions & 10 deletions cmd/root.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,6 @@ import (
"github.com/evilmartians/lefthook/internal/log"
)

var commands = [...]func(*lefthook.Options) *cobra.Command{
newVersionCmd,
newAddCmd,
newInstallCmd,
newUninstallCmd,
newRunCmd,
newDumpCmd,
newUpgradeCmd,
}

func newRootCmd() *cobra.Command {
options := lefthook.Options{
Fs: afero.NewOsFs(),
Expand Down
244 changes: 2 additions & 242 deletions cmd/upgrade.go
View file
Original file line number Diff line number Diff line change
@@ -1,66 +1,18 @@
package cmd

import (
"bufio"
"context"
"crypto/sha256"
"encoding/hex"
"encoding/json"
"errors"
"fmt"
"io"
"net/http"
"os"
"os/signal"
"path/filepath"
"runtime"
"strings"
"syscall"
"time"

"github.com/schollz/progressbar/v3"
"github.com/spf13/cobra"

"github.com/evilmartians/lefthook/internal/lefthook"
"github.com/evilmartians/lefthook/internal/log"
"github.com/evilmartians/lefthook/internal/version"
"github.com/evilmartians/lefthook/internal/upgrader"
)

const (
timeout = 10 * time.Second
latestReleaseURL = "https://api.github.com/repos/evilmartians/lefthook/releases/latest"
checksumsFilename = "lefthook_checksums.txt"
modExecutable os.FileMode = 0o755
)

var (
errNoAsset = errors.New("Couldn't find an asset to download. Please submit an issue to https://github.com/evilmartians/lefthook")
errInvalidHashsum = errors.New("SHA256 sum differs")

osNames = map[string]string{
"windows": "Windows",
"darwin": "MacOS",
"linux": "Linux",
"freebsd": "Freebsd",
}

archNames = map[string]string{
"amd64": "x86_64",
"arm64": "arm64",
"386": "i386",
}
)

type Release struct {
TagName string `json:"tag_name"`
Assets []Asset
}

type Asset struct {
Name string `json:"name"`
DownloadURL string `json:"browser_download_url"`
}

func newUpgradeCmd(opts *lefthook.Options) *cobra.Command {
var yes bool
upgradeCmd := cobra.Command{
Expand Down Expand Up @@ -105,197 +57,5 @@ func upgrade(opts *lefthook.Options, yes bool) error {
cancel()
}()

client := &http.Client{
Timeout: timeout,
}
release, ferr := fetchLatestRelease(ctx, client)
if ferr != nil {
return fmt.Errorf("latest release fetch failed: %w", ferr)
}

latestVersion := strings.TrimPrefix(release.TagName, "v")

if latestVersion == version.Version(false) && !opts.Force {
log.Infof("Already installed the latest version: %s\n", latestVersion)
return nil
}

wantedAsset := fmt.Sprintf("lefthook_%s_%s_%s", latestVersion, osNames[runtime.GOOS], archNames[runtime.GOARCH])
if runtime.GOOS == "windows" {
wantedAsset += ".exe"
}

log.Debugf("Searching assets for %s", wantedAsset)

var downloadURL string
var checksumURL string
for i := range release.Assets {
asset := release.Assets[i]
if len(downloadURL) == 0 && asset.Name == wantedAsset {
downloadURL = asset.DownloadURL
if len(checksumURL) > 0 {
break
}
}

if len(checksumURL) == 0 && asset.Name == checksumsFilename {
checksumURL = asset.DownloadURL
if len(downloadURL) > 0 {
break
}
}
}

if len(downloadURL) == 0 {
log.Warnf("Couldn't find the right asset to download. Wanted: %s\n", wantedAsset)
return errNoAsset
}

if len(checksumURL) == 0 {
log.Warn("Couldn't find checksums")
}

if !yes {
log.Infof("Do you want to upgrade lefthook to %s? [Y/n] ", latestVersion)
scanner := bufio.NewScanner(os.Stdin)
scanner.Scan()
ans := scanner.Text()

if len(ans) > 0 && ans[0] != 'y' && ans[0] != 'Y' {
log.Debug("Upgrade rejected")
return nil
}
}

lefthookExePath, err := os.Executable()
if err != nil {
return fmt.Errorf("failed to determine the binary path: %w", err)
}

if realPath, serr := filepath.EvalSymlinks(lefthookExePath); serr == nil {
lefthookExePath = realPath
}

destPath := lefthookExePath + "." + latestVersion
defer os.Remove(destPath)

log.Debugf("Downloading to %s", destPath)
ok, err := download(ctx, client, wantedAsset, downloadURL, checksumURL, destPath)
if err != nil {
return err
}
if !ok {
return errInvalidHashsum
}

backupPath := lefthookExePath + ".bak"
defer os.Remove(backupPath)

log.Debugf("Renaming %s -> %s", lefthookExePath, backupPath)
if err = os.Rename(lefthookExePath, backupPath); err != nil {
return fmt.Errorf("failed to backup lefthook executable: %w", err)
}

log.Debugf("Renaming %s -> %s", destPath, lefthookExePath)
err = os.Rename(destPath, lefthookExePath)
if err != nil {
log.Errorf("Failed to replace the lefthook executable: %s\n", err)
if err = os.Rename(backupPath, lefthookExePath); err != nil {
return fmt.Errorf("failed to recover from backup: %w", err)
}

return nil
}

log.Debugf("Making file %s executable", lefthookExePath)
if err = os.Chmod(lefthookExePath, modExecutable); err != nil {
return fmt.Errorf("failed to set mod executable: %w", err)
}

return nil
}

func fetchLatestRelease(ctx context.Context, client *http.Client) (*Release, error) {
req, err := http.NewRequestWithContext(ctx, http.MethodGet, latestReleaseURL, nil)
if err != nil {
return nil, fmt.Errorf("failed to initialize a request: %w", err)
}
req.Header.Set("Accept", "application/vnd.github+json")
req.Header.Set("X-GitHub-Api-Version", "2022-11-28")

resp, err := client.Do(req)
if err != nil {
return nil, fmt.Errorf("request failed: %w", err)
}
defer resp.Body.Close()

var release Release
if err = json.NewDecoder(resp.Body).Decode(&release); err != nil {
return nil, fmt.Errorf("failed to parse the Github response: %w", err)
}

return &release, nil
}

func download(ctx context.Context, client *http.Client, name, fileURL, checksumURL, path string) (bool, error) {
filereq, err := http.NewRequestWithContext(ctx, http.MethodGet, fileURL, nil)
if err != nil {
return false, fmt.Errorf("failed to build download request: %w", err)
}

sumreq, err := http.NewRequestWithContext(ctx, http.MethodGet, checksumURL, nil)
if err != nil {
return false, fmt.Errorf("failed to build checksum download request: %w", err)
}

file, err := os.Create(path)
if err != nil {
return false, fmt.Errorf("failed to create destination path (%s): %w", path, err)
}
defer file.Close()

resp, err := client.Do(filereq)
if err != nil {
return false, fmt.Errorf("download request failed: %w", err)
}
defer resp.Body.Close()

checksumResp, err := client.Do(sumreq)
if err != nil {
return false, fmt.Errorf("checksum download request failed: %w", err)
}
defer checksumResp.Body.Close()

bar := progressbar.DefaultBytes(resp.ContentLength+checksumResp.ContentLength, name)

fileHasher := sha256.New()
if _, err = io.Copy(io.MultiWriter(file, fileHasher, bar), resp.Body); err != nil {
return false, fmt.Errorf("failed to download the file: %w", err)
}
log.Debug()

hashsum := hex.EncodeToString(fileHasher.Sum(nil))

scanner := bufio.NewScanner(checksumResp.Body)
for scanner.Scan() {
sums := strings.Fields(scanner.Text())
log.Debugf("Checking %s %s", sums[0], sums[1])
if sums[1] == name {
if sums[0] == hashsum {
if err = bar.Finish(); err != nil {
log.Debugf("Progressbar error: %s", err)
}

log.Debugf("Match %s %s", sums[0], sums[1])

return true, nil
} else {
return false, nil
}
}
}

log.Debugf("No matches found for %s %s\n", name, hashsum)

return false, nil
return upgrader.New().Upgrade(ctx, yes, opts.Force)
}
Loading

0 comments on commit 3985e5f

Please sign in to comment.