Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kid claim to JWE header of JARM #254

Merged
merged 3 commits into from
May 29, 2024
Merged

Add kid claim to JWE header of JARM #254

merged 3 commits into from
May 29, 2024

Conversation

babisRoutis
Copy link
Contributor

Closes #253

@babisRoutis babisRoutis requested a review from a team as a code owner May 28, 2024 17:34
@babisRoutis babisRoutis added this to the SiopOpenId4VP-v0.4.1 milestone May 28, 2024
@babisRoutis babisRoutis requested a review from vafeini May 28, 2024 17:37
@babisRoutis
Copy link
Contributor Author

babisRoutis commented May 28, 2024 •
edited
Loading

Hi @vafeini please double check this.
Currently fix is applied when JARM is encrypted, but not signed.

vafeini
vafeini previously approved these changes May 29, 2024
View reviewed changes
@babisRoutis babisRoutis merged commit 326557d into eu-digital-identity-wallet:main May 29, 2024
4 checks passed
@babisRoutis babisRoutis deleted the fix/add-kid-to-jarm branch May 29, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vafeini vafeini vafeini left review comments

Assignees
No one assigned
Labels
bug Something isn't working interoperability iso-18013-7
Projects
None yet
Milestone
SiopOpenId4VP-v0.4.1
Development

Successfully merging this pull request may close these issues.

Missing kid from JWE header of JARM
2 participants
@babisRoutis @vafeini