-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DID and verifier attesation schemes #245
Merged
babisRoutis
merged 20 commits into
eu-digital-identity-wallet:main
from
niscy-eudiw:feat/support-did-and-verifier-attestation-schemes
May 20, 2024
Merged
Support DID and verifier attesation schemes #245
babisRoutis
merged 20 commits into
eu-digital-identity-wallet:main
from
niscy-eudiw:feat/support-did-and-verifier-attestation-schemes
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@babisRoutis |
dzarras
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for two additional
client_id_scheme
(s)did
verifier_attestation
DID
To be used wallet needs to add to its configuration an instance of
SupportedClientIdScheme.DID
.Effectually, to do so, it has to provide a way to lookup verifier's public key using a DID URL via DID resolution.
The later is out of scope of the library
Verifier Attestation
To be used wallet needs to add to its configuration an instance of
SupportedClientIdScheme.VerifierAttestation
.To do so, wallet has to provide a
JWSVerifier
capable of verifying the signature of verifier attestation JWT from trusted issuers.Closes #244
Closes #126