Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DID and verifier attesation schemes #245

Conversation

babisRoutis
Copy link
Contributor

This PR adds support for two additional client_id_scheme(s)

  • did
  • verifier_attestation

DID

To be used wallet needs to add to its configuration an instance of SupportedClientIdScheme.DID.
Effectually, to do so, it has to provide a way to lookup verifier's public key using a DID URL via DID resolution.
The later is out of scope of the library

Verifier Attestation

To be used wallet needs to add to its configuration an instance of SupportedClientIdScheme.VerifierAttestation.
To do so, wallet has to provide a JWSVerifier capable of verifying the signature of verifier attestation JWT from trusted issuers.

Closes #244
Closes #126

@babisRoutis babisRoutis added feature New feature or request draft20 labels May 17, 2024
@babisRoutis babisRoutis added this to the SiopOpenId4VP-v0.4.0 milestone May 17, 2024
@babisRoutis babisRoutis requested a review from a team as a code owner May 17, 2024 18:26
@dzarras
Copy link
Contributor

dzarras commented May 20, 2024

@babisRoutis java.net.URI is not the best option to parse DIDs/DIDURLs. For instance check here how Example 6 did:example:123?service=agent&relativeRef=/credentials#degree from did-core is parsed.

@babisRoutis babisRoutis merged commit 0f808dc into eu-digital-identity-wallet:main May 20, 2024
4 checks passed
@babisRoutis babisRoutis deleted the feat/support-did-and-verifier-attestation-schemes branch May 20, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft20 feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support did scheme Support verifier_attestation scheme
2 participants